Repository navigation
Incorrect suggestion in while_let_on_iterator if iterator cannot be moved #8113
Description
Summary
Same as #7846, but for while_let_on_iterator
Lint Name
while_let_on_iterator
Reproducer
I tried this code:
fn main() {
let mut arr = [vec![1, 2, 3].into_iter()];
while let Some(x) = arr[0].next() {}
}I saw this happen:
warning: this loop could be written as a `for` loop
--> src\main.rs:3:5
|
3 | while let Some(x) = arr[0].next() {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in arr[0]`
|
= note: `#[warn(clippy::while_let_on_iterator)]` on by default
the suggestion causes the error
error[E0508]: cannot move out of type `[std::vec::IntoIter<i32>; 1]`, a non-copy array
--> src\main.rs:3:14
|
3 | for x in arr[0] {}
| ^^^^^^
| |
| cannot move out of here
| move occurs because `arr[_]` has type `std::vec::IntoIter<i32>`, which does not implement the `Copy` trait
I expected to see this happen:
No lint emitted
Version
rustc 1.59.0-nightly (e6b883c74 2021-12-08)
binary: rustc
commit-hash: e6b883c74f49f32cb5d1cbad3457f2b8805a4a38
commit-date: 2021-12-08
host: x86_64-pc-windows-msvc
release: 1.59.0-nightly
LLVM version: 13.0.0
Additional Labels
@rustbot label +I-suggestion-causes-error
Reacted by John T. Wodder II
Activity
WaffleLapkin commentedon Dec 9, 2021
I don't think it's false positive, as there can be correct suggestion:
i.e. if iterator can't be moved we should suggest using unique references to the said iterator
[-]False positive in `while_let_on_iterator` if iterator cannot be moved[/-][+]Incorrect suggestion in `while_let_on_iterator` if iterator cannot be moved[/+]Alexendoo commentedon Dec 9, 2021
@rustbot label -I-suggestion-causes-error
Alexendoo commentedon Dec 9, 2021
Whoops, wrong one 👀
@rustbot label +I-suggestion-causes-error -I-false-positive
Auto merge of #8221 - Jarcho:while_let_on_iterator_8113, r=llogiq
Auto merge of #8221 - Jarcho:while_let_on_iterator_8113, r=llogiq