Repository navigation
don't warn on CRLF in with_newline lints - #4769
Merged
Merged
Conversation
phansch
added
the
S-waiting-on-review
flip1995
reviewed
Nov 6, 2019
| ); | ||
|
|
||
| // Don't warn on CRLF (#4208) | ||
| print!("\r\n"); |
Member
There was a problem hiding this comment.
Another test case: print!("foo\rbar\n");
euclio
force-pushed
the
crlf
branch
2 times, most recently
from
November 7, 2019 03:11
4c40a50 to
1329dc2
Compare
Member
|
@bors r+ rollup |
Contributor
|
📌 Commit 1329dc2 has been approved by |
Contributor
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 7, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes rust-lang#4208. This PR also transitions the unescaping logic to use the compiler's lexer.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 7, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes rust-lang#4208. This PR also transitions the unescaping logic to use the compiler's lexer.
Contributor
bors
added a commit
that referenced
this pull request
Nov 7, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes #4208. This PR also transitions the unescaping logic to use the compiler's lexer.
Contributor
|
💔 Test failed - checks-travis |
Member
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 9, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes #4208. This PR also transitions the unescaping logic to use the compiler's lexer.
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Contributor
|
☔ The latest upstream changes (presumably #4802) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
@bors r=flip1995 |
Contributor
|
📌 Commit 403ce3f has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Nov 11, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes #4208. This PR also transitions the unescaping logic to use the compiler's lexer.
Contributor
|
💔 Test failed - status-appveyor |
Contributor
|
This needs to be rebased agains upstream master. |
Member
|
@bors r+ |
Contributor
|
📌 Commit add7664 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 12, 2019
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes #4208. This PR also transitions the unescaping logic to use the compiler's lexer.
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: don't warn on CRLF in
print_with_newlineandwrite_with_newlinefixes #4208.
This PR also transitions the unescaping logic to use the compiler's lexer.