Repository navigation
write_with_newline should not warn when "\n" is preceded by "\r" #4208
Description
Writing to a file, I need CRLF format so I have no other choice than using write with \r\n.
warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
--> src\main.rs:49:13
|
49 | write!(out, "{}\r\n", line)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(clippy::write_with_newline)] on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
Reacted by Felipe S. S. Schneider
Activity
wip fix for rust-lang#4208
V1shvesh commentedon Sep 10, 2019
Hey @Geobert @matthiaskrgr! Is this issue still relevant?
flip1995 commentedon Sep 11, 2019
Yes it is. matthiaskrgr/rust-clippy@588dcc8 didn't fix this back then, and I think @matthiaskrgr probably forgot about this in the mean time. So feel free to take this 👍
V1shvesh commentedon Sep 11, 2019
Awesome!
bookshelfdave commentedon Sep 13, 2019
hi @V1shvesh are you working on this issue? If not, I have a fix.
V1shvesh commentedon Sep 16, 2019
@metadave I haven't worked on it yet, so feel free! Thanks!
matthiaskrgr commentedon Oct 2, 2019
PR has been integrated, I'm closing this. :)
flip1995 commentedon Oct 3, 2019
No, it's
S-inactive-closed, not merged. Only thing left to do is to add a test and the PR is finished.Rollup merge of rust-lang#4769 - euclio:crlf, r=flip1995
Rollup merge of rust-lang#4769 - euclio:crlf, r=flip1995
Auto merge of #4769 - euclio:crlf, r=flip1995
Auto merge of #4769 - euclio:crlf, r=flip1995
Auto merge of #4769 - euclio:crlf, r=flip1995
Auto merge of #4769 - euclio:crlf, r=flip1995