Repository navigation
Revert #335 (Trap TSTP to handle C-z) - #535
Merged
Merged
Conversation
This PR was an effort to address ruby#321 (ed_quoted_insert doesn't work properly) but per the reporter it did not work correctly. Moreover, it introduced a major regression: Shell job control stopped working in all applications that use reline, notably IRB. Bash and other shells send SIGTSTP in response to C-z to implement job suspension. Handling SIGSTP opts out of this functionality. For a line oriented terminal program this should be avoided (not to mention, this behavior diverges from readline's)
tompng
approved these changes
Apr 24, 2023
tompng
left a comment
tompng
left a comment
Member
There was a problem hiding this comment.
Thank you, It make sense to revert it 👍
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 24, 2023
(ruby/reline#535) This PR was an effort to address #321 (ed_quoted_insert doesn't work properly) but per the reporter it did not work correctly. Moreover, it introduced a major regression: Shell job control stopped working in all applications that use reline, notably IRB. Bash and other shells send SIGTSTP in response to C-z to implement job suspension. Handling SIGSTP opts out of this functionality. For a line oriented terminal program this should be avoided (not to mention, this behavior diverges from readline's) ruby/reline@26383d25b8 Co-authored-by: Carl Brasic <cbrasic@drwholdings.com>
Member
|
(memo for the future) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
#335 was an effort to address #321 (ed_quoted_insert doesn't work properly) but per the reporter the change did not work correctly.
Moreover, it introduced a major regression: Shell job control stopped working in all applications that use reline, notably IRB.
Shells send SIGTSTP in response to SUSP (C-z) to implement the suspension part of job control. Adding a handler for SIGTSTP opts out of this functionality. For a line oriented terminal program this should be avoided when possible (not to mention, this behavior diverges from readline's)
cc @aycabta