Skip to content

Cleanup PreparedLayoutTextView Recycling #55554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 1 commit into from
Closed

Cleanup PreparedLayoutTextView Recycling #55554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...native/ReactAndroid/src/main/java/com/facebook/react/views/text/PreparedLayoutTextView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,17 @@ internal class PreparedLayoutTextView(context: Context) : ViewGroup(context), Re
@DoNotStrip get() = preparedLayout?.layout?.text

init {
initView()
// ViewGroup by default says only its children will draw
setWillNotDraw(false)
}

private fun initView() {
clickableSpans = emptyList()
selection = null
preparedLayout = null
}

fun recycleView(): Unit {
initView()
BackgroundStyleApplicator.reset(this)
overflow = Overflow.HIDDEN
clickableSpans = emptyList()
selection = null
selectionColor = null
preparedLayout = null
}

override fun onDraw(canvas: Canvas) {
Expand Down
Loading