Repository navigation
Cleanup PreparedLayoutTextView Recycling - #55554
Closed
NickGerleman wants to merge 1 commit into
Closed
NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Summary: Everything in `initView` is already initialized implicitly, so should only be called during recycling, where we are also missing `selectionColor`. Changelog: [internal] Differential Revision: D93327082
meta-cla
Bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93327082. |
cortinico
approved these changes
Feb 16, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @NickGerleman in 22b9b3b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 22b9b3b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Everything in
initViewis already initialized implicitly, so should only be called during recycling, where we are also missingselectionColor.Changelog: [internal]
Differential Revision: D93327082