Repository navigation
Conversation
Author
|
Closing this: I misdiagnosed the failures in the daily run. The only third-party failure in run 40425880002's shard 1 was grpcio-health-checking (already covered by #16623), and the stdlib failures are covered by #16624. The two allowlist entries removed here are still needed: with the versions the stubs declare support for (aiofiles 25.1.0, setuptools 84.0.0) on Python 3.13, the underlying mismatches still occur, as this PR's own CI run shows. My local reproduction ran stubtest on Python 3.10 and 3.14, where these entries appear unused, but typeshed's third-party stubtest matrix runs on 3.13 only, and I did not read the actual daily job log before authoring the removals. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily stubtest run failed with unused allowlist entries in these two stubs:
https://github.com/python/typeshed/actions/runs/40425880002
Reproduced both failures locally on current main with
tests/stubtest_third_party.pyand verified the fixes:aiofiles: stubtest reports the allowlist entryaiofiles.os.linkas unused (reproduced on Python 3.10 and 3.14). After removing the entry,stubtest_third_party.py aiofilespasses.setuptools: stubtest reports the allowlist entrysetuptools._distutils._modified.newer_pairwise_groupas unused (reproduced on Python 3.10). After removing the entry,stubtest_third_party.py setuptoolspasses.Only the two unused allowlist lines are removed; no stub changes.
Related: #16622. The grpcio-health-checking failure from the same run is already handled in #16623.
This PR was prepared with AI assistance.