Skip to content

Remove unused stubtest allowlist entries (aiofiles, setuptools) - #16628

Closed
anish-yen wants to merge 2 commits into
python:mainfrom
anish-yen:fix-unused-allowlist-entries
Closed

anish-yen wants to merge 2 commits into
python:mainfrom
anish-yen:fix-unused-allowlist-entries

Conversation

@anish-yen

Copy link
Copy Markdown

The daily stubtest run failed with unused allowlist entries in these two stubs:
https://github.com/python/typeshed/actions/runs/40425880002

Reproduced both failures locally on current main with tests/stubtest_third_party.py and verified the fixes:

  • aiofiles: stubtest reports the allowlist entry aiofiles.os.link as unused (reproduced on Python 3.10 and 3.14). After removing the entry, stubtest_third_party.py aiofiles passes.
  • setuptools: stubtest reports the allowlist entry setuptools._distutils._modified.newer_pairwise_group as unused (reproduced on Python 3.10). After removing the entry, stubtest_third_party.py setuptools passes.

Only the two unused allowlist lines are removed; no stub changes.

Related: #16622. The grpcio-health-checking failure from the same run is already handled in #16623.

This PR was prepared with AI assistance.

@anish-yen

Copy link
Copy Markdown
Author

Closing this: I misdiagnosed the failures in the daily run.

The only third-party failure in run 40425880002's shard 1 was grpcio-health-checking (already covered by #16623), and the stdlib failures are covered by #16624. The two allowlist entries removed here are still needed: with the versions the stubs declare support for (aiofiles 25.1.0, setuptools 84.0.0) on Python 3.13, the underlying mismatches still occur, as this PR's own CI run shows.

My local reproduction ran stubtest on Python 3.10 and 3.14, where these entries appear unused, but typeshed's third-party stubtest matrix runs on 3.13 only, and I did not read the actual daily job log before authoring the removals. Sorry for the noise.

@anish-yen anish-yen closed this Oct 27, 2026
@anish-yen
anish-yen deleted the fix-unused-allowlist-entries branch October 27, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant