Skip to content

[grpcio-health-checking] Add the Health List RPC from 1.85 - #16623

Merged
srittau merged 2 commits into
python:mainfrom
hoangchunghien:grpcio-health-checking-list
Oct 28, 2026
Merged

srittau merged 2 commits into
python:mainfrom
hoangchunghien:grpcio-health-checking-list

Conversation

@hoangchunghien

Copy link
Copy Markdown
Contributor

grpcio-health-checking 1.85.0 adds a List method to the grpc.health.v1.Health service, with two new messages. Last night's stubtest run (#16622) reports all four as missing:

grpc_health.v1.health_pb2.HealthListRequest is not present in stub
grpc_health.v1.health_pb2.HealthListResponse is not present in stub
grpc_health.v1.health_pb2_grpc.Health.List is not present in stub
grpc_health.v1.health_pb2_grpc.HealthServicer.List is not present in stub

This adds:

  • HealthListRequest (no fields) and HealthListResponse, with its statuses map (MessageMap[str, HealthCheckResponse]) and the nested StatusesEntry. The shapes follow upstream's generated health_pb2.pyi in 1.85.0 and are written in this file's existing style.
  • HealthServicer.List and the static Health.List, mirroring Check.

HealthListRequest.__init__ goes in a new @tests/stubtest_allowlist.txt. The upb runtime signature is (self, /, *args, **kwargs), and a message with no fields takes no arguments, so the stub is narrower on purpose. stubtest suggested exactly that entry.

The concrete servicers in health.py and _async.py don't implement List in 1.85.0, so they are unchanged.

Checked locally against grpcio-health-checking 1.85.0: stubtest_third_party.py grpcio-health-checking passes, as do mypy_test.py, pyright_test.py, check_typeshed_structure.py, flake8 and black 26.10.0.

Refs #16622 (the stdlib email._header_value_parser failures in the same run are not covered here).

grpcio-health-checking 1.85.0 adds a List method to the grpc.health.v1
Health service, with HealthListRequest and HealthListResponse messages.
The daily stubtest run reports all four as missing (python#16622).
@github-actions

This comment has been minimized.

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the version in METADATA.toml, possibly to 1.85.*.

@hoangchunghien

Copy link
Copy Markdown
Contributor Author

Bumped version to "1.85.*" in METADATA.toml (1.85.0 is the current release). stubtest for grpcio-health-checking still passes.

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau
srittau merged commit 3706bbd into python:main Oct 28, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants