Repository navigation
[grpcio-health-checking] Add the Health List RPC from 1.85 - #16623
Merged
Merged
Conversation
grpcio-health-checking 1.85.0 adds a List method to the grpc.health.v1 Health service, with HealthListRequest and HealthListResponse messages. The daily stubtest run reports all four as missing (python#16622).
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 27, 2026
srittau
requested changes
Oct 27, 2026
srittau
left a comment
Collaborator
There was a problem hiding this comment.
We should also bump the version in METADATA.toml, possibly to 1.85.*.
Contributor
Author
|
Bumped |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpcio-health-checking 1.85.0 adds a
Listmethod to thegrpc.health.v1.Healthservice, with two new messages. Last night's stubtest run (#16622) reports all four as missing:This adds:
HealthListRequest(no fields) andHealthListResponse, with itsstatusesmap (MessageMap[str, HealthCheckResponse]) and the nestedStatusesEntry. The shapes follow upstream's generatedhealth_pb2.pyiin 1.85.0 and are written in this file's existing style.HealthServicer.Listand the staticHealth.List, mirroringCheck.HealthListRequest.__init__goes in a new@tests/stubtest_allowlist.txt. The upb runtime signature is(self, /, *args, **kwargs), and a message with no fields takes no arguments, so the stub is narrower on purpose. stubtest suggested exactly that entry.The concrete servicers in
health.pyand_async.pydon't implementListin 1.85.0, so they are unchanged.Checked locally against grpcio-health-checking 1.85.0:
stubtest_third_party.py grpcio-health-checkingpasses, as domypy_test.py,pyright_test.py,check_typeshed_structure.py, flake8 and black 26.10.0.Refs #16622 (the stdlib
email._header_value_parserfailures in the same run are not covered here).