Skip to content

Fix setuptools CI issue - #9400

Merged
hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:hmm
Sep 2, 2020
Merged

hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:hmm

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Sep 2, 2020 •

Copy link
Copy Markdown
Collaborator

No description provided.

@gvanrossum

Copy link
Copy Markdown
Member

If this works, maybe combine with my idea and try "setuptools!=50.0" in both places?

@hauntsaninja hauntsaninja changed the title does it work Fix setuptools CI issue Sep 2, 2020
@hauntsaninja

hauntsaninja commented Sep 2, 2020 •

Copy link
Copy Markdown
Collaborator Author

Great, this seems to work.

Errors like cl : Command line warning D9002 : ignoring unknown option '/O0' smelt like we weren't using the right compiler. In mypyc/build.py, we gets the C compiler from from distutils import sysconfig, ccompiler, which is close enough that I continued to be suspicious. Maybe a separate setuptools issue though

@hauntsaninja
hauntsaninja marked this pull request as ready for review September 2, 2020 22:59

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to land.

But we should eventually support newer setuptools versions too, otherwise we'll just break in a different way in the future, and it'll be another wild goose change.

@hauntsaninja

Copy link
Copy Markdown
Collaborator Author

Sure, I'll file an issue. So continues the packaging treadmill...

@hauntsaninja
hauntsaninja merged commit 5906a5d into python:master Sep 2, 2020
@hauntsaninja
hauntsaninja deleted the hmm branch September 2, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants