Skip to content

Unpin setuptools #9401

Closed
Closed

Description

@hauntsaninja

#9400 pins us to setuptools<50

Once the burning has stopped (to quote pypa/setuptools#2376), we should unpin this. One day, everything will work.

Also while I'm here, a couple months ago I pinned virtualenv<20 to fix CI. virtualenv might work for us now, so another thing we could unpin.

Activity

  1. hauntsaninja commented on Sep 6, 2020

    @hauntsaninja
    CollaboratorAuthor

    Should be easy to find something that works, now that setuptools has merged and released that PR.

  2. vhawk19 commented on Sep 9, 2020

    @vhawk19

    @hauntsaninja Could I work on this issue? I am relatively new to the open source ecosystem, but would like to contribute. Would this be a good first issue for me to pick up?

  3. hauntsaninja commented on Sep 10, 2020

    @hauntsaninja
    CollaboratorAuthor

    Welcome! Of course, go ahead. I suspect simply undoing #9400 should work (as judged by CI passing). If so, you could maybe exclude the problematic setuptools versions in the version constraint. However, if that doesn't work / you're unfamiliar with Python packaging, you might want to try another issue.

    https://github.com/python/mypy/blob/master/CONTRIBUTING.md has more general guidance

  4. harshest2019 commented on Sep 13, 2020

    @harshest2019

    @hauntsaninja I am new here as well and want to start contributing to open source, i have sound knowledge of python and i am eager to learn.
    Please guide me on what to do and where to get started, it would help me a lot and I hope then i will be able to help open source community as well.
    Thank You.

  5. gvanrossum commented on Sep 13, 2020

    @gvanrossum
    Member

    @harshest2019 I'm sorry, but a specific issue like this is not an appropriate place to ask for guidance with your first steps contributing. Please use the Gitter channel linked from the repo's README.md. Also study the CONTRIBUTING.mg file in the repo.

  6. harshest2019 commented on Sep 13, 2020

    @harshest2019

    @gvanrossum I am sorry sir, I will do as you asked.
    Thank You and please excuse my mistake.

  7. Cyatos commented on Sep 22, 2020

    @Cyatos
    Contributor

    @hauntsaninja Is this issue still up for grabs? I'd like to raise a PR if one hasn't been raised already.

  8. gvanrossum commented on Sep 22, 2020

    @gvanrossum
    Member

    @Cyatos Please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions