Skip to content

Append dummy path to file creation URL - #637

Merged
pipecd-bot merged 1 commit into
masterfrom
append-path
Aug 17, 2020
Merged

pipecd-bot merged 1 commit into
masterfrom
append-path

Conversation

@nakabonne

@nakabonne nakabonne commented Aug 17, 2020 •

Copy link
Copy Markdown
Member

What this PR does / why we need it:
We're getting an issue with specifying a filename: isaacs/github#1527
In short, the last path part of the URL is ignored when specifying a filename. For now, appending dummy path as a workaround.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot

Copy link
Copy Markdown
Collaborator

COVERAGE

Code coverage for golang is 21.59%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/git/url.go MakeFileCreationURL 100.00% 100.00% +0.00%

@nghialv

nghialv commented Aug 17, 2020

Copy link
Copy Markdown
Member

/approve

@pipecd-bot

Copy link
Copy Markdown
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
pipecd-bot merged commit f6cad1e into master Aug 17, 2020
@pipecd-bot
pipecd-bot deleted the append-path branch August 17, 2020 08:17
@pipecd-bot

Copy link
Copy Markdown
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants