Skip to content

Prototype CloudRund deployment with the new design of deployment configuration - #660

Merged
pipecd-bot merged 3 commits into
masterfrom
cloudrun
Aug 20, 2020
Merged

Prototype CloudRund deployment with the new design of deployment configuration#660
pipecd-bot merged 3 commits into
masterfrom
cloudrun

Conversation

@nghialv

@nghialv nghialv commented Aug 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
pipecd-bot requested review from gkuga and nakabonne August 20, 2020 04:48
pipecd-bot
pipecd-bot reviewed Aug 20, 2020
View reviewed changes

@pipecd-bot pipecd-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

Comment thread pkg/app/piped/cloudprovider/cloudrun/client.go Resolved
@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

COVERAGE

Code coverage for golang is 20.63%. This pull request decreases coverage by -0.29%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/cloudrun/servicemanifest.go FindImageTag -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensurePromote -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.loadServiceManifest -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.loadLastDeployedServiceManifest -- 0.00% +0.00%
pkg/app/piped/planner/cloudrun/cloudrun.go Planner.determineVersion -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureRollback 0.00% 0.00% +0.00%
pkg/app/piped/planner/cloudrun/cloudrun.go Planner.Plan 0.00% 0.00% +0.00%
pkg/config/deployment.go PipelineStage.UnmarshalJSON 40.00% 41.94% +1.94%
pkg/app/piped/cloudprovider/cloudrun/servicemanifest.go DecideRevisionName 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Register 83.33% 80.00% -3.33%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.Execute 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureSync 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureCanaryRollout 0.00% -- +-0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureTrafficRouting 0.00% -- +-0.00%
pkg/config/deployment_cloudrun.go CloudRunTrafficRoutingStageOptions.Percentages 0.00% -- +-0.00%

nakabonne
nakabonne reviewed Aug 20, 2020
View reviewed changes
Comment thread pkg/app/piped/executor/cloudrun/cloudrun.go Resolved
@nghialv nghialv changed the title Prototype CloudRund deployment with the new design of deployment Prototype CloudRund deployment with the new design of deployment configuration Aug 20, 2020
@nghialv @nakabonne
Update pkg/app/piped/executor/cloudrun/cloudrun.go
3f75d3a 
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Wait to ensure the traffic was fully configured.

https://github.com/pipe-cd/pipe/blob/3f75d3a2d1954a73d5247d96772d7d8f1adc2840/pkg/app/piped/executor/cloudrun/cloudrun.go#L208-L211

This was created by todo plugin since "TODO:" was found in 3f75d3a when #660 was merged. cc: @nghialv.

1 similar comment
@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Wait to ensure the traffic was fully configured.

https://github.com/pipe-cd/pipe/blob/3f75d3a2d1954a73d5247d96772d7d8f1adc2840/pkg/app/piped/executor/cloudrun/cloudrun.go#L208-L211

This was created by todo plugin since "TODO:" was found in 3f75d3a when #660 was merged. cc: @nghialv.

@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@nakabonne

nakabonne commented Aug 20, 2020

Copy link
Copy Markdown
Member

/approve

@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

COVERAGE

Code coverage for golang is 20.63%. This pull request decreases coverage by -0.29%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/cloudrun/servicemanifest.go FindImageTag -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensurePromote -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.loadServiceManifest -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.loadLastDeployedServiceManifest -- 0.00% +0.00%
pkg/app/piped/planner/cloudrun/cloudrun.go Planner.determineVersion -- 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureRollback 0.00% 0.00% +0.00%
pkg/app/piped/planner/cloudrun/cloudrun.go Planner.Plan 0.00% 0.00% +0.00%
pkg/config/deployment.go PipelineStage.UnmarshalJSON 40.00% 41.94% +1.94%
pkg/app/piped/cloudprovider/cloudrun/servicemanifest.go DecideRevisionName 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Register 83.33% 80.00% -3.33%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.Execute 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureSync 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureCanaryRollout 0.00% -- +-0.00%
pkg/app/piped/executor/cloudrun/cloudrun.go Executor.ensureTrafficRouting 0.00% -- +-0.00%
pkg/config/deployment_cloudrun.go CloudRunTrafficRoutingStageOptions.Percentages 0.00% -- +-0.00%

@pipecd-bot
pipecd-bot merged commit af35864 into master Aug 20, 2020
@pipecd-bot
pipecd-bot deleted the cloudrun branch August 20, 2020 05:28
@pipecd-bot pipecd-bot mentioned this pull request Aug 20, 2020
Closed
@nghialv

nghialv commented Aug 20, 2020

Copy link
Copy Markdown
Member Author

/changelog

@pipecd-bot

pipecd-bot commented Aug 20, 2020

Copy link
Copy Markdown
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.3.0

Notable Changes

No notable changes for this release

Internal Changes

  • Prototype CloudRund deployment with the new design of deployment configuration (#660)
  • Update build dependencies (#659)
  • Recreate CloudRun prototype by using Google API instead of gcloud tool (#658)
  • Implement the form to update github sso settings (#656)
  • Implement the project setting page to update static admin info (#655)
  • Add terraform to piped-base image (#654)
  • Prototype terraform deployment (#652)
  • Update the layout of deployment cell in list page (#650)
  • Update user-guide docs (#649)
  • Prototype cloudrun deployment (#646)
  • Fix some form titles (#647)
  • Fix the title of table header at application list page (#645)
  • Implement rpcs that update the project settings. (#642)
  • Filter pipeds by environment at the add application form (#641)
  • Update dev tools to the latest version (#640)
  • Add docs for ADA (#631)
  • Enable a control character to line break on the stage log view (#638)
  • Append dummy path to file creation URL (#637)
  • Fix the position of log header and change log break property (#636)
  • Ensure to generate file creation URL (#635)
  • Update primary color for docs (#634)
  • Change theme colors (#633)
  • Add gcloud to piped-base image (#629)
  • Preinstall only the latest version of tools to reduce the size of piped-base image (#628)
  • Add some links to detail pages (#625)
  • Implement rpc interfaces that update the project data. (#620)
  • Add Namespace to built-in args (#624)
  • Fix the layout of configuring-application docs (#621)
  • Update the cancel button for deployment (#619)
  • Better log messages of ADA (#618)
  • Fix a bug that causes piped crashes while rolling back (#617)
  • Add ability to force running rollback or not after cancelling (#615)
  • Fix a bug that piped was unable to be registered (#616)
  • Ensure that piped must belong to at least one environment (#611)
  • Support Gitlab and Bitbucket to make dir URL (#613)
  • Fix style issues (#610)
  • Update user-guide docs (#607)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pipecd-bot pipecd-bot pipecd-bot left review comments
@gkuga gkuga Awaiting requested review from gkuga
+1 more reviewer
@nakabonne nakabonne nakabonne left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/docs area/piped area/site release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nghialv @pipecd-bot @nakabonne