Repository navigation
Add custom replacement to custom rules - #375
Closed
felipe-gustavo wants to merge 5 commits into
Closed
felipe-gustavo wants to merge 5 commits into
felipe-gustavo wants to merge 5 commits into
Conversation
This reverts commit bd6cf27.
This will allow custom rules to add custom overrides/replacements, such as:
```
Validator.register(
'date_between',
function (value, requirement) {
// custom validation using dates
},
'Custom message for attribute :attribute with replacements :min and :max.',
function (template, rule) {
parameters = rule.getParameters();
return {
min: parameters[0],
max: parameters[1],
};
},
)
```
Add condition if the custom replacement response not is a object to replace
Owner
|
Merged |
mikeerickson
left a comment
Owner
There was a problem hiding this comment.
Would you mind adding a test to cover this PR. I am willing to add the PR, but will need tests to cover to make sure there is no side affect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow custom rules to add custom overrides/replacements, such as:
Edit 1:
This will meet this requirement/issue( #136 )