Skip to content

Custom replacements not working for custom rules #440

Open

Description

@sanjacornelius

In version 3.22.1, when using the provided example for creating custom attributes the :min and :max parameters are not returned.

In doing a little investigation version 3.22.1 seems to be missing some code from PR #375 that implemented the feature. When adding back the missing code the provided example works as expected.

Not sure if it was intended and if there is a different way the custom replacements need to be implemented in this version. A little guidance would be helpful thank you in advance!

Provided Example from Docs

Validator.register(
    'date_between',
    function (value, requirement) {
      // custom validation using dates
    },
    'Custom message for attribute :attribute with replacements :min and :max.',
    function (_template, rule, _getAttributeName) {
      const parameters = rule.getParameters();
        return {
          min: parameters[0],
          max: parameters[1],
        };
    }
);

Activity

  1. ethaizone commented on Nov 19, 2021

    @ethaizone

    I think this happen due some mistake. As we can see that fnReplacement is exists but it's unused.

    Validator.register = function (name, fn, message, fnReplacement) {
    var lang = Validator.getDefaultLang();
    Rules.register(name, fn);
    Lang._setRuleMessage(lang, name, message);
    };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions