Skip to content

Revert "Update Foundry Local SDK to 2.1.0" - #342681

Merged
Megan Rogge (meganrogge) merged 1 commit into
mainfrom
revert-341640-fix/341152-foundry-language
Oct 19, 2026
Merged

Megan Rogge (meganrogge) merged 1 commit into
mainfrom
revert-341640-fix/341152-foundry-language

Conversation

@meganrogge

Copy link
Copy Markdown
Collaborator

Reverts #341640

This caused issues

Copilot AI balanced review requested due to automatic review settings October 19, 2026 20:38
@meganrogge Megan Rogge (meganrogge) added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Oct 19, 2026
@meganrogge Megan Rogge (meganrogge) added this to the 1.144.0 milestone Oct 19, 2026
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) October 19, 2026 20:38
@vs-code-engineering

Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.143 when merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The diff exactly reverses #341640 and keeps dependency metadata and test expectations consistent.

No open issues 🎉

What changed in this PR

Reverts #341640 to restore Foundry Local SDK 2.0.1 following reported issues.

Changes:

  • Restores the SDK version, lockfile metadata, and install-script permission.
  • Restores matching dictation runtime test fixtures and expectations.

No actionable findings remain. Tests were not run.

File Description
package.json Restores SDK 2.0.1 and its install-script permission.
package-lock.json Restores the previous SDK resolution and integrity hash.
build/​lib/​test/​dictationRuntime.test.ts Restores previous ONNX dependency versions and expectations.

Review effort: Balanced

@meganrogge
Megan Rogge (meganrogge) merged commit 1155fd0 into main Oct 19, 2026
51 checks passed
@meganrogge
Megan Rogge (meganrogge) deleted the revert-341640-fix/341152-foundry-language branch October 19, 2026 21:29
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Oct 19, 2026
@amIsmael

Copy link
Copy Markdown

Hi,

Thanks for the quick revert. This restores the behavior from #341152: local
dictation with agents.voice.language: "es" falls back to English and leaks
<en-US>.

Is there a tracking issue for re-landing the 2.1.0 language fix once the runtime
crash is resolved? #341152 is currently closed as completed, so nothing open
references this regression. #340656 describes the same behavior from the 2.0.1
SDK and is still open, but untriaged.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants