Repository navigation
fix(macos): let a ScrollView scroll over a multiline TextInput - #3146
Open
Bron Davies (brondavies) wants to merge 1 commit into
Open
Bron Davies (brondavies) wants to merge 1 commit into
Bron Davies (brondavies) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Thiago Vinhas (tvinhas)
added a commit
to tvinhas/react-native-macos
that referenced
this pull request
Oct 28, 2026
Upstream v0.88.1 (30 commits, replayed onto the local v0.88.0 without the agent files). Conflicts: fork identities and the vlists '*' peer kept; Hermes 260318099.0.5; RCTStatusBarAppearance, the modal's status bar capture and RCTRootViewController are iOS-only (macOS has no status bar, visionOS lacks setNeedsStatusBarAppearanceUpdate); the SwiftUI filter container sets safeAreaRegions through RCTPlatformHostingController; SwiftPM autolinking keeps the per-platform UIKit/AppKit linker settings; RNTester Podfile.lock regenerated with pod install. Also from microsoft/react-native-macos (open PRs, macOS-only): secure TextInput focus crash (microsoft#3141), TextInput color for bullets and plain text (microsoft#3144), TextInput text stays put when resized while focused (microsoft#3150), ScrollView scrolls over a multiline TextInput (microsoft#3146), inverted lists on the new architecture (microsoft#3148), press over a TextInput (microsoft#3143), Dimensions follow window resizes (microsoft#3142, plus removing its observer on invalidate), RCTView shadow color retained (microsoft#3129), UIImage encoders extern "C" (microsoft#3140), layout direction constants (microsoft#3131), and codegen skipping unlinked third-party components (microsoft#3128, upstream react#59067). .yarnrc.yml preapproves hermes-compiler@260318099.0.5 past the 7-day age gate.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On macOS, a
ScrollViewdoesn't scroll while the pointer is over a multilineTextInputinside it.RCTWrappedTextViewkeeps its text in anNSScrollView, which keeps every scroll event it's sent, even with nothing to scroll.Its scroll view now passes on any scroll its text can't follow. While the text fits, or with
scrollEnabled={false}, that's every scroll. Once the text overflows, it's a scroll past the top or bottom. It decides when a gesture starts: on each wheel notch, or on a trackpad's MayBegin or Began. So a gesture and its momentum stay with one scroll view.Test Plan:
RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2). The Playground had a
ScrollViewholding an empty multilineTextInput, one with 30 lines, and a 600pt spacer. I sent wheel events from lldb to the text view hit-tested under each input:main(same build, the scroll view's class swapped back toRCTUIScrollView), theScrollViewstays put over both inputs, even with the long one scrolled to its end.ScrollView30pt, and back. Over the long one, the input scrolls to its end (14 notches), then theScrollViewscrolls. Going up, the input scrolls back to its top, then theScrollViewfollows.It's the same in an app on 0.83.0 with this patched in.
I checked trackpad gestures in a standalone AppKit harness: the MayBegin and Began events decide, and the rest follows. I didn't check them with a real trackpad.