Repository navigation
fix(macos): stop a secure TextInput throwing as it takes focus - #3141
Open
Bron Davies (brondavies) wants to merge 1 commit into
Open
Bron Davies (brondavies) wants to merge 1 commit into
Bron Davies (brondavies) wants to merge 1 commit into
Conversation
Since RCTUISecureTextField became an RCTUITextField subclass with an NSSecureTextFieldCell (microsoft#2895), AppKit refuses it as the secure field editor's delegate: -[NSSecureTextView setDelegate:] throws "NSSecureTextFieldCell is not secure because the secure field editor's delegate must be an NSSecureTextField!" when the field becomes first responder. It now answers isKindOfClass: for NSSecureTextField. NSSecureTextView then also sends it -_shouldShowIndicators while drawing, which NSSecureTextField answers from a flag that is off by default, so it answers NO.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Thiago Vinhas (tvinhas)
added a commit
to tvinhas/react-native-macos
that referenced
this pull request
Oct 28, 2026
Upstream v0.88.1 (30 commits, replayed onto the local v0.88.0 without the agent files). Conflicts: fork identities and the vlists '*' peer kept; Hermes 260318099.0.5; RCTStatusBarAppearance, the modal's status bar capture and RCTRootViewController are iOS-only (macOS has no status bar, visionOS lacks setNeedsStatusBarAppearanceUpdate); the SwiftUI filter container sets safeAreaRegions through RCTPlatformHostingController; SwiftPM autolinking keeps the per-platform UIKit/AppKit linker settings; RNTester Podfile.lock regenerated with pod install. Also from microsoft/react-native-macos (open PRs, macOS-only): secure TextInput focus crash (microsoft#3141), TextInput color for bullets and plain text (microsoft#3144), TextInput text stays put when resized while focused (microsoft#3150), ScrollView scrolls over a multiline TextInput (microsoft#3146), inverted lists on the new architecture (microsoft#3148), press over a TextInput (microsoft#3143), Dimensions follow window resizes (microsoft#3142, plus removing its observer on invalidate), RCTView shadow color retained (microsoft#3129), UIImage encoders extern "C" (microsoft#3140), layout direction constants (microsoft#3131), and codegen skipping unlinked third-party components (microsoft#3128, upstream react#59067). .yarnrc.yml preapproves hermes-compiler@260318099.0.5 past the 7-day age gate.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #3138.
A
TextInputwithsecureTextEntrycrashes as it takes focus on macOS.-[NSSecureTextView setDelegate:]requires anNSSecureTextFieldand throws "NSSecureTextFieldCell is not secure because the secure field editor's delegate must be an NSSecureTextField!". Since #2895,RCTUISecureTextFieldsubclassesRCTUITextField, with anNSSecureTextFieldCellfor the masking and secure input.This change makes the field answer
isKindOfClass:forNSSecureTextField. That alone is not enough:NSSecureTextViewthen sends its delegate-_shouldShowIndicatorsas it draws, and the unrecognised selector throws from-[NSSecureTextView drawRect:]. We used theisKindOfClass:half alone in our app first, and it crashed that way a few minutes into using the field.NSSecureTextFieldanswers that one from a flag that only its private setter turns on, so the field answers NO, as a real one does. From AppKit's disassembly, it's the onlyNSSecureTextField-only messageNSSecureTextViewsends its delegate.The alternative is for
RCTUISecureTextFieldto be a realNSSecureTextFieldsubclass again, which #2895 moved away from. This keeps #2895's structure; happy to go the other way if you'd rather not answer a private selector.Test Plan:
RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2), Playground showing
<TextInput secureTextEntry={true} placeholder="Password" style={{borderWidth: 1, height: 30}} />:main, callingfocus()on the field terminates the app with the exception in macOS: a secure TextInput crashes the app when it takes focus #3138.secretputs 6 characters in the field editor;NSSecureTextView;[firstResponder _shouldShowIndicators], evaluated in lldb, goes through the delegate path that crashed indrawRect:and returns NO.