[Vincent Biret (baywet)]

Summary

• Closes Guid JSON parse converter precedence bypasses custom converter for standard GUID strings #793.
• Adds regression coverage proving a custom Guid converter is used for standard GUID strings.
• Updates JsonParseNode.GetGuidValue to deserialize through the Kiota JSON serialization context before falling back to JsonElement.TryGetGuid.

Validation

• dotnet test tests\serialization\json\Microsoft.Kiota.Serialization.Json.Tests.csproj --filter "FullyQualifiedName~JsonParseNodeTests.ParseGuid" --no-restore currently fails to build on latest main because JsonParseNodeTests references JsonTimeSpanConverter, but that converter file is not present on this scoped branch/main.

[Copilot]

🟡 Changes recommended

Newly added TimeSpan tests reference a missing JsonTimeSpanConverter and don’t match current TimeSpan parsing behavior, so the test project will not build/pass as-is.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses #793 by ensuring JsonParseNode.GetGuidValue honors the configured KiotaJsonSerializationContext (and thus custom JsonConverter<Guid> implementations) before falling back to JsonElement.TryGetGuid, and adds regression coverage for the precedence behavior.

Changes:

• Update JsonParseNode.GetGuidValue(JsonElement) to attempt GUID deserialization through the Kiota JSON serialization context first, then fall back to TryGetGuid.
• Add a regression test proving a custom GUID converter is invoked even for standard "D" GUID strings.
• Add a test-only JsonGuidPrecedenceConverter used to validate converter precedence.

File summaries

File	Description
tests/serialization/json/JsonParseNodeTests.cs	Adds regression coverage for GUID converter precedence (but also introduces unrelated TimeSpan converter tests).
tests/serialization/json/Converters/JsonGuidPrecedenceConverter.cs	Adds a test-only GUID converter used to validate precedence.
src/serialization/json/JsonParseNode.cs	Changes GUID parsing order to prefer KiotaJsonSerializationContext deserialization before TryGetGuid.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The updated GUID parsing path removes the prior context-deserialization fallback when TryGetGuid fails, which changes behavior and can cause previously-parsable GUID strings to become null.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

GetGuidValue currently removes the prior context-based deserialization fallback when TryGetGuid fails, which changes existing behavior and conflicts with the stated compatibility requirement.

Review details

Suppressed comments (1)

src/serialization/json/JsonParseNode.cs:331

• GetGuidValue no longer falls back to JsonSerializerContext-based deserialization when JsonElement.TryGetGuid fails (unless a custom Guid converter is detected). This changes prior behavior (previously it would deserialize via _jsonSerializerContext.Guid for non-empty strings), and can return null for Guid string formats that TryGetGuid doesn’t accept or for option-driven Guid handling, violating the PR’s “preserve existing behavior when no custom converter is configured” requirement.

            if(HasCustomGuidConverter() && TryGetUsingTypeInfo(jsonElement, _jsonSerializerContext.Guid, out var convertedGuid))
                return convertedGuid;

            return jsonElement.TryGetGuid(out var guid)
                ? guid

• Files reviewed: 3/3 changed files
• Comments generated: 0 new
• Review effort level: Lite

[github-code-quality]

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 0e5fd2d in the fix/guid-json-conver... branch is 51%. The line coverage in commit 73b19e0 in the main branch is 52%.

Show a line coverage summary of the most impacted files.

File	main 73b19e0	fix/guid-json-conver... 0e5fd2d	+/-
Events.cs	37%	31%	-6%
RecyclableMemoryStream.cs	43%	42%	-1%
RecyclableMemor...treamManager.cs	31%	30%	-1%
D:\a\kiota-dotn...sonParseNode.cs	91%	91%	0%

---

_{Updated September 04, 2026 19:06 UTC}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud