Repository navigation
Honor custom DateTimeOffset converters - #791
Merged
Vincent Biret (baywet) merged 5 commits intoSep 8, 2026
Merged
Vincent Biret (baywet) merged 5 commits into
Vincent Biret (baywet) merged 5 commits into
Conversation
Vincent Biret (baywet)
previously approved these changes
Sep 4, 2026
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
shubmittal
force-pushed
the
fix-datetimeoffset-converter-692
branch
from
September 4, 2026 18:40
fbd219f to
a5ad954
Compare
Vincent Biret (baywet)
previously approved these changes
Sep 4, 2026
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Vincent Biret (baywet)
enabled auto-merge (squash)
September 4, 2026 18:42
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts: # src/serialization/json/JsonParseNode.cs
Vincent Biret (baywet)
approved these changes
Sep 8, 2026
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the reported regression with targeted converter detection and adds regression tests for both the custom-converter and fallback paths.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTimeOffsetconverters before built-in parsing.Fixes #692
Validation
AI assistance
GitHub Copilot helped implement and validate this change.