Skip to content

Template string aren't recognized by classifier #1884

Closed
Closed
Template string aren't recognized by classifier#1884
Labels
DuplicateAn existing issue was already createdFixedA PR has been merged for this issue

Description

@jrieken
Johannes Rieken (jrieken)
opened on Feb 2, 2015

https://github.com/Microsoft/TypeScript/blob/ab9ce1e9e6636ec6a2aa4f01458525f249c4edf5/src/services/services.ts#L1172

I would expect them to get a special treatment. For instance

`Hello ${name}`

could have tokens like: string(Hello), punct(${), identifier(name), punct(}), string()

Activity

  1. DanielRosenwasser commented on Feb 2, 2015

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Feb 2, 2015
    Member

    Duplicate of #1698, #1716, and #1477. In #1477 I give an explanation of the technical difficulties associated with highlighting a context free construct template strings, however, I decided that it was an inappropriate experience so now we just do our best to propagate template state across lines. #1744 has a fix.

  2. Daniel Rosenwasser (DanielRosenwasser)
    added
    DuplicateAn existing issue was already created
    on Feb 2, 2015
  3. Ryan Cavanaugh (RyanCavanaugh)
    closed this as completedon Feb 2, 2015
  4. Daniel Rosenwasser (DanielRosenwasser)
    added
    FixedA PR has been merged for this issue
    on Feb 13, 2015

  5. DanielRosenwasser commented on Feb 13, 2015

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Feb 13, 2015
    Member

    A fix is now in master through #2026.

  6. microsoft
    locked and limited conversation to collaborators on Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DuplicateAn existing issue was already createdFixedA PR has been merged for this issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions