String templates not colorized in VS 2013 #1698

Activity

1. Mohamed Hegazy (mhegazy)

   added

   BugA bug in TypeScriptA bug in TypeScript

   Visual StudioIntegration with Visual StudioIntegration with Visual Studio

   on Jan 16, 2015
2. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 1.5 milestone on Jan 16, 2015
3. Mohamed Hegazy (mhegazy)

   assigned

   Daniel Rosenwasser (DanielRosenwasser)

   on Jan 16, 2015
4. Daniel Rosenwasser (DanielRosenwasser)

   added

   By DesignDeprecated - use "Working as Intended" or "Design Limitation" insteadDeprecated - use "Working as Intended" or "Design Limitation" instead

   DuplicateAn existing issue was already createdAn existing issue was already created

   on Jan 16, 2015
5. DanielRosenwasser commented on Jan 16, 2015

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Jan 16, 2015

   Member

   More actions

   Duplicate of #1477, see my comment for an explanation of the technical difficulties associated with this: #1477 (comment) .

   Though, we could enhance the lexical classifier, but I don't know if it's really worth it.
6. Daniel Rosenwasser (DanielRosenwasser)

   added

   Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptThe issue relates to the different libraries shipped with TypeScript

   Won't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix it

   Too ComplexAn issue which adding support for may be too complex for the value it addsAn issue which adding support for may be too complex for the value it adds

   and removed

   By DesignDeprecated - use "Working as Intended" or "Design Limitation" insteadDeprecated - use "Working as Intended" or "Design Limitation" instead

   Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptThe issue relates to the different libraries shipped with TypeScript

   on Jan 16, 2015
7. Daniel Rosenwasser (DanielRosenwasser)

   closed this as completedon Jan 16, 2015
8. Daniel Rosenwasser (DanielRosenwasser)

   removed this from the TypeScript 1.5 milestone on Jan 18, 2015
9. Daniel Rosenwasser (DanielRosenwasser)

   removed their assignment

   on Jan 18, 2015
10. NoelAbrahams commented on Jan 19, 2015

    

    Noel Abrahams (NoelAbrahams)

    on Jan 19, 2015

    More actions

    Daniel Rosenwasser (@DanielRosenwasser), colour would really help

    

    The template string version is more difficult to comprehend.
11. DanielRosenwasser commented on Jan 20, 2015

    

    Daniel Rosenwasser (DanielRosenwasser)

    on Jan 20, 2015

    Member

    More actions

    Noel Abrahams (@NoelAbrahams) I understand that. This is probably a lousy experience for most people, and as the one who implemented templates, I personally felt like I owed our users something a little better. This afternoon I whipped something up.

    I have a branch from which you can build the source code and swap out your language service in VS2013. The specific commit (e42ce9c) can be cherry picked onto the release-1.4 branch.

    Basically, as long as your template strings' substitutions don't contain:

    • Expressions with closing curly braces on a separate line
    • Other substitution template strings that span multiple lines

    this should fit your needs.

    If it doesn't, well, you probably have other problems to worry about. 😉
12. NoelAbrahams commented on Jan 20, 2015

    

    Noel Abrahams (NoelAbrahams)

    on Jan 20, 2015

    More actions

    Daniel Rosenwasser (@DanielRosenwasser), will try that out. Do you mean to say that in VS 2015 this should be coloured correctly? (A bug in NTVS is preventing us from using VS 2015 atm, but we should be migrating soon.)

    Thanks!
13. DanielRosenwasser commented on Jan 20, 2015

    

    Daniel Rosenwasser (DanielRosenwasser)

    on Jan 20, 2015

    Member

    More actions

    You're very welcome! Let me know how this works out for you. Yes, 2015 should already work with template colorization.

    That's unfortunate - does the Node Tools team know about the bug?
14. NoelAbrahams commented on Jan 21, 2015

    

    Noel Abrahams (NoelAbrahams)

    on Jan 21, 2015

    More actions

    Yes, there's a discussion item.
15. Daniel Rosenwasser (DanielRosenwasser)

    added

    FixedA PR has been merged for this issueA PR has been merged for this issue

    and removed

    Won't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix it

    on Feb 13, 2015
16. Daniel Rosenwasser (DanielRosenwasser)

    self-assigned this

    on Feb 13, 2015
17. DanielRosenwasser commented on Feb 13, 2015

    

    Daniel Rosenwasser (DanielRosenwasser)

    on Feb 13, 2015

    Member

    More actions

    A fix is now in master through #2026.
18. Daniel Rosenwasser (DanielRosenwasser)

    removed

    Too ComplexAn issue which adding support for may be too complex for the value it addsAn issue which adding support for may be too complex for the value it adds

    on Feb 13, 2015
19. microsoft

    locked and limited conversation to collaborators on Jun 18, 2018