Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakweg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If klog contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @jakweg! |
|
Please fix the PR description so that it has a self-contained description of the problem without relying on broken links. |
|
Done, thanks |
What this PR does / why we need it:
Tests should be independent and repeatable. It’s a pain to debug a test that succeeds or fails as a result of other tests.
klog_test.gocontains test cases that need to be executed in the order of declaration to pass. This PR fixes this problem in the fileklog_test.go.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #441
Special notes for your reviewer:
None
Release note: