Skip to content

klog_test.go contains test cases that need to be executed in the order of declaration to pass. #441

Open

Description

@jakweg

/kind feature

Describe the solution you'd like
Tests should be independent and repeatable. It’s a pain to debug a test that succeeds or fails as a result of other tests. An order-dependent test might not test what you think it does, potentially hiding a bug in the worst case.

Anything else you would like to add:

klog_test.go contains test cases that need to be executed in the order of declaration to pass.

A simple deductive analysis of randomized test results shows that TestVInfoS always fails when [TestSetVState, TestV, TestHeader, TestShortHostname, TestCommandLine, TestFileSizeCheck, TestHeaderWithDir, TestInfoS, TestInitFlags] do not run before it, and always passes otherwise.

Activity

  1. added
    kind/featureCategorizes issue or PR as related to a new feature.
    needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
    on Oct 30, 2026
  2. kubernetes-prow commented on Oct 30, 2026

    @kubernetes-prow

    This issue is currently awaiting triage.

    If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

    The triage/accepted label can be added by org members by writing /triage accepted in a comment.

    Details

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions