[jdx]

https://entire.io/gh/jdx/mise/trails/782

Follows #14520. On a Windows host, mise lock recorded nothing for ruby on linux-* and macos-* platforms, so refreshing a shared lockfile from Windows still dropped those entries and mise install --locked failed on them. With this change a Windows host produces the same entries a Linux host does:

> mise lock --platform linux-x64,windows-x64   # ruby = "4.0.7"

[[tools.ruby]]
version = "4.0.7"
backend = "core:ruby"
specifiers = ["4.0.7"]

[tools.ruby.options]
compile = "false"
precompiled_url = "jdx/ruby"
ruby_build_repo = "https://github.com/rbenv/ruby-build.git"
ruby_install = "false"

[tools.ruby."platforms.linux-x64"]
checksum = "sha256:..."
url = "https://github.com/jdx/ruby/releases/download/4.0.7-2/ruby-4.0.7.x86_64_linux.tar.gz"
provenance = "github-attestations"

Windows builds compile ruby_windows.rs instead of ruby.rs, so the logic that picks the precompiled archive, verifies its attestation, falls back to the source tarball and computes the lock options only existed in ruby.rs. That logic now lives in a new ruby_lock.rs that both files use; ruby.rs behaves as before. Settings::ruby_compile is no longer Windows-excluded because the shared code reads it.

Together with #14520 this completes #14517.

Tested: the existing ruby unit tests pass on Linux (40), clippy with -D warnings is clean, and cargo check --lib --tests --target x86_64-pc-windows-gnu compiles. A new Windows-only unit test checks the Linux lock options and the empty Windows options from a Windows host. I could not run mise lock on a Windows machine from here.

Fixes #14517.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

🤖 Generated with Claude Code

---

Note

Medium Risk
Changes cross-platform lockfile generation and Ruby download/attestation resolution paths used during mise lock; behavior on Unix should be a refactor, but Windows lock output for other platforms is newly exercised.

Overview
Windows hosts can now write the same ruby lockfile entries for Linux and macOS that Unix hosts already produced, so refreshing a shared lockfile on Windows no longer drops non-Windows platform blocks and breaks mise install --locked elsewhere.

Lock resolution for precompiled GitHub assets, source tarballs from cache.ruby-lang.org, attestation checks, and lock options (compile, precompiled_url, ruby-build settings, etc.) is extracted into a new ruby_lock module compiled on all platforms. The Unix ruby.rs backend delegates resolve_lockfile_options / resolve_lock_info to shared lock_options / lock_info; ruby_windows.rs does the same instead of returning empty PlatformInfo for non-Windows targets.

Settings::ruby_compile is no longer gated with #[cfg(not(windows))], so the shared lock path can read compile/precompiled settings when locking from Windows.

A Windows-only unit test asserts Linux lock options are populated while Windows targets still get an empty options map.

^{Reviewed by Cursor Bugbot for commit 6bfa19a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Improvements
  • Ruby installation lockfiles now resolve platform-appropriate install details across Windows and other supported platforms.
  • Where available, precompiled Ruby packages are selected; source builds can use Ruby source archives with checksum information.
  • Ruby package attestation checks follow the configured verification settings, and enabled checks can report failures.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2357d380-ab22-4ddb-b021-aaa783afd958

📥 Commits

Reviewing files that changed from the base of the PR and between 530e8d0 and 6bfa19a.

📒 Files selected for processing: 5

• src/config/settings.rs
• src/plugins/core/mod.rs
• src/plugins/core/ruby.rs
• src/plugins/core/ruby_lock.rs
• src/plugins/core/ruby_windows.rs

💤 Files with no reviewable changes: 1

• src/config/settings.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Ruby lockfile resolution is moved into a shared module. The Ruby compile setting is available on Windows. The resolver now provides platform-specific lock options and lock info for Windows and other targets, including source archives, precompiled assets, and attestation checks.

Changes: Ruby lockfile resolution

Layer / File(s)	Summary
Lock inputs and target selection src/config/settings.rs, src/plugins/core/mod.rs, src/plugins/core/ruby.rs, src/plugins/core/ruby_lock.rs	The Ruby compile setting is available on all platforms. The new module adds source-index lookup, precompiled selection, platform mapping, and build-revision parsing.
Precompiled artifact resolution src/plugins/core/ruby.rs, src/plugins/core/ruby_lock.rs	Precompiled release lookup, URL resolution, and GitHub attestation verification are moved into the shared module.
Platform lock integration src/plugins/core/ruby.rs, src/plugins/core/ruby_lock.rs, src/plugins/core/ruby_windows.rs	Lock-option and lock-info methods delegate to the shared helpers. Windows uses RubyInstaller2 lock info and returns empty lock options. A test checks Linux and Windows lock options.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: risu729, marukome0743

Merge Risk: ⚪ Minimal · up to 6bfa1

Running mise lock on Windows should now record Linux and macOS Ruby entries alongside the Windows entry, so shared lockfiles no longer lose Ruby platform data. No concrete defect was found, and Ruby behavior on other platforms is unchanged. The change appears ready to merge; a quick mise lock run on a Windows machine would confirm it end to end.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 28 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: enabling Ruby Linux and macOS platform entries when running mise lock on Windows.
Linked Issues check		Issue #14517 requires Windows mise lock to write Ruby entries for windows-x64 and requested non-Windows targets. src/plugins/core/ruby_lock.rs contains shared target-aware resolution for precomp…
Out of Scope Changes check		The changes stay within issue #14517. The new ruby_lock module extracts Ruby lockfile resolution for reuse, the Windows backend uses it for requested targets, Settings::ruby_compile is available t…

Full details: Linked Issues check

Explanation

Issue #14517 requires Windows mise lock to write Ruby entries for windows-x64 and requested non-Windows targets. src/plugins/core/ruby_lock.rs contains shared target-aware resolution for precompiled assets, source archives, checksums, provenance, and lock options. src/plugins/core/ruby_windows.rs delegates both lock methods to this shared implementation. The Windows target keeps empty Ruby build options, while Linux and macOS targets receive the shared options and platform metadata. The added Windows-only test verifies Linux options and empty Windows options. These changes address the issue coding requirements.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #14517. The new ruby_lock module extracts Ruby lockfile resolution for reuse, the Windows backend uses it for requested targets, Settings::ruby_compile is available to the shared Windows lock path, and the tests cover the new behavior. No unrelated change is demonstrated.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Shares Ruby lockfile code between the Unix and Windows backends. Windows hosts can now record Linux and macOS archives instead of returning empty platform details.

• Windows lock runs now include Ruby entries for Linux and macOS targets.

_{Reviews (1) · Last reviewed commit: "fix(ruby): lock linux and macos platform..." · Reviewed by Greptile}

[github-actions]

Instruction counts

Nothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does.

New, nothing to compare against: env on jdx-perf-v1-ubuntu24.04-x64-mise-rust1.97.1-img5263c143, hook-env on jdx-perf-v1-ubuntu24.04-x64-mise-rust1.97.1-img5263c143, ls on jdx-perf-v1-ubuntu24.04-x64-mise-rust1.97.1-img5263c143, registry on jdx-perf-v1-ubuntu24.04-x64-mise-rust1.97.1-img5263c143, startup on jdx-perf-v1-ubuntu24.04-x64-mise-rust1.97.1-img5263c143

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{6bfa19a9a999 vs 530e8d085dbf · measured on the runner, not pushed to the history.}