[garysassano]

Installation hooks currently report the configured request and installed version, but cannot identify the backend or exact installation directory that completed. This adds backend and install_path to each MISE_INSTALLED_TOOLS entry, deriving both from the installation result so successful entries remain useful during partial failures and do not depend on a second configuration lookup.

The existing fields and hook timing remain unchanged. URL credentials are removed from backend identifiers while meaningful SSH usernames are preserved, and non-Unicode path behavior is documented. Documentation distinguishes installation completion from configuration selection, floating-link updates, and adoption by a running application, including no-op and failure behavior.

Verification:

• mise run test:e2e -- test_hooks_installed_tools
• mise run lint
• Native CI validates the current head, including the focused unit and E2E coverage added after review

AI-assisted — Tool: OpenAI Codex; model: OpenAI/GPT-6; version: unavailable.

Summary by CodeRabbit

• New Features

  • Postinstall tool data now includes the installation backend and exact installation path, alongside tool name and version details.
  • Hook payloads now accurately report tools successfully installed during batch operations, including when another installation fails.

• Documentation

  • Updated hook documentation with the expanded payload format, field descriptions, examples, and clarification of when installation information is reported.
  • Clarified when service refreshes should occur in relation to explicit upgrade workflows.

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b414db75-c707-4b3c-a266-30c01a2372f2

📥 Commits

Reviewing files that changed from the base of the PR and between 429630f and fd58dac.

📒 Files selected for processing (1)

• e2e-win/dotfiles_watch.Tests.ps1

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The postinstall payload now includes each tool's backend and exact installation path. Installation records are captured immediately after installation, preserved during partial failures, serialized with opaque versions, and documented with updated semantics.

Changes

Installed tools payload

Layer / File(s)	Summary
Payload contract and serialization src/hooks.rs, docs/hooks.md	InstalledToolInfo now includes backend and install_path fields. Tests cover opaque versions, URL sanitization, and platform paths. Documentation describes the five-field payload and its installation-completion semantics.
Installation capture and hook output src/toolset/toolset_install.rs, e2e/config/test_hooks_installed_tools, e2e-win/dotfiles_watch.Tests.ps1	Successful installation records are captured before later configuration changes and reused by the postinstall hook. End-to-end tests verify metadata fields, isolated install directories, no-op behavior, partial failures, and watcher cleanup.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant InstallCommand
  participant install_with_deps
  participant InstalledToolInfo
  participant PostinstallHook
  InstallCommand->>install_with_deps: Install requested tool versions
  install_with_deps-->>InstallCommand: Return successful installations
  InstallCommand->>InstalledToolInfo: Build backend and install_path records
  InstallCommand->>PostinstallHook: Pass installed tool records

Loading

Suggested reviewers: jdx

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: exposing the installed tool backend and installation path in hooks.

Full details: Docstring Coverage

Explanation

Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (1 skipped: 1 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; no actionable new issue or outstanding previous finding remains.

Summary

This PR expands each MISE_INSTALLED_TOOLS postinstall-hook entry with the backend that performed the installation and the concrete installation directory.

• Captures metadata directly from successful installation results, including successes retained during partial batch failures.
• Sanitizes URL-based backend identifiers while preserving meaningful SSH usernames.
• Documents payload timing, no-op and partial-failure behavior, activation boundaries, and lossy representation of non-Unicode paths.
• Adds focused serialization and end-to-end coverage and strengthens Windows watcher cleanup.

_{Reviews (14) · Last reviewed commit: "Merge branch 'main' into feat/hook-insta..."}

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.

[github-actions]

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

[garysassano]

The failing Windows E2E job reported 286 passed tests and 0 failed tests, then failed Pester container cleanup because the new upstream dotfiles_watch service still held the test directory open after task removal. The failure repeated across all three workflow attempts.

Commit fd58dac6c adds a bounded Wait-Watcher $false after service and scheduled-task removal so Pester only deletes the test directory after the watcher releases it. This is a separate follow-up commit; the hook implementation and the merge from main remain unchanged.

PowerShell parser validation passes locally. The pushed head will provide native Windows E2E evidence.

[garysassano]

Exact-head Windows evidence is now green on 53744a1d2:

• Windows build: passed
• Windows unit: passed
• Windows E2E: passed in 10m14s, including dotfiles_watch.Tests.ps1
• Linux build, E2E, lint, docs, bootstrap, CodeRabbit, and Greptile: passed

The previous Pester test-directory cleanup failure is resolved. The macOS unit job is still completing; no exact-head check is failing.