Repository navigation
fix: backport login and namespace ownership conflict fixes to 1.3.x - #2383
Merged
Merged
Conversation
(cherry picked from commit c96a639)
… has an owner Backport of #2380 to 1.3.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
httpcore5 5.4.3 and later reject header lines over 8192 bytes. GitHub's token response now carries a longer Content-Security-Policy header, so the code exchange failed with "Maximum line length limit exceeded" and login broke. Build the token client on an HttpClient with a 64 KiB line limit. Backport of #2381 to 1.3.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t fixes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of two fixes to the
1.3.xbranch, created from thev1.3.0tag. The fixes are applied as plain diffs, not cherry-picks.Commits
chore: fix changelog after 1.3.0 has been released(c96a639ffrommain): thev1.3.0tag still has## [next]holding all of 1.3.0's entries. This adds the## [1.3.0] - 2026-10-16heading so the new entries land under[next].fix: stop reporting a namespace ownership conflict once the namespace has an owner: backport of fix: stop reporting a namespace ownership conflict once the namespace has an owner #2380.fix: accept OAuth token responses with long headers: backport of fix: accept OAuth token responses with long headers #2381. The OAuth token response carries aContent-Security-Policyheader longer than httpcore5's default 8192-byte line limit (5.4.3 and later), so the code exchange failed withMaximum line length limit exceededand GitHub login broke. The token client now uses an HttpClient with a 64 KiB limit.docs: add changelog entries ...: the entries for 2 and 3 under[next]/ Fixed. The messages of 2 and 3 say "without the changelog entry"; the entries are in this separate commit.Testing
spotlessCheckand theorg.eclipse.openvsx.security.*,UserAPITestandAdminAPITesttests pass on this branch (227 tests). The newTokenResponseClientsTestfails with the exact login error when the limit is 8192 (verified onmain). The full./gradlew testsuite was not run, and a login against real GitHub was not tried on this branch.🤖 Generated with Claude Code