Repository navigation
fix: stop reporting a namespace ownership conflict once the namespace has an owner - #2380
Merged
Merged
Conversation
… has an owner The conflict flag on the admin and own-extension endpoints came from the threat the NamespaceOwnershipCheckScanner recorded on the latest scan. That record is never cleared, so the "Namespace not verified" notice stayed after the namespace gained an owner and the extension was activated. Report the conflict only while the namespace is unverified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
netomi
added a commit
that referenced
this pull request
Oct 23, 2026
…2382) * fix: stop reporting a namespace ownership conflict once the namespace has an owner Backport of #2380 to 1.2.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix: accept OAuth token responses with long headers httpcore5 5.4.3 and later reject header lines over 8192 bytes. GitHub's token response now carries a longer Content-Security-Policy header, so the code exchange failed with "Maximum line length limit exceeded" and login broke. Build the token client on an HttpClient with a 64 KiB line limit. Backport of #2381 to 1.2.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
netomi
added a commit
that referenced
this pull request
Oct 24, 2026
…2383) * chore: fix changelog after 1.3.0 has been released (cherry picked from commit c96a639) * fix: stop reporting a namespace ownership conflict once the namespace has an owner Backport of #2380 to 1.3.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix: accept OAuth token responses with long headers httpcore5 5.4.3 and later reject header lines over 8192 bytes. GitHub's token response now carries a longer Content-Security-Policy header, so the code exchange failed with "Maximum line length limit exceeded" and login broke. Build the token client on an HttpClient with a 64 KiB line limit. Backport of #2381 to 1.3.x, without the changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * docs: add changelog entries for the 1.3.x login and namespace conflict fixes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Namespace not verified" notice on the admin extension page and on a publisher's own extension settings stayed after the namespace gained an owner and the extension was activated. One example is
jay-boo/gitland: the public API reports both it and its namespace asverified: true.Cause
namespaceOwnershipConflictwas taken only from the threat theNamespaceOwnershipCheckScannerrecorded on the latest version's scan. Nothing clears that record, neither adding an owner nor activating the extension, so the flag stayed true for good. The namespace page usesrepositories.isVerified(namespace)and correctly showed the namespace as verified.Fix
Report the conflict only while the namespace is still unverified (
!repositories.isVerified(namespace)). This applies inAdminAPI(GET /admin/extension/{namespace}/{extension}) and inUserAPI(GET /user/extensionsandGET /user/extension/{namespace}/{extension}). The scan threat stays recorded as history.Testing
AdminAPITestandUserAPITest: a recorded ownership threat on a namespace that has an owner reports no conflict. Both fail without the fix../gradlew test(full suite) andspotlessCheckpass.🤖 Generated with Claude Code