Skip to content

[main] Update dependencies from nuget/nuget.client - #49743

Closed
dotnet-maestro[bot] wants to merge 9 commits into
mainfrom
darc-main-824d2701-0e73-4e18-807f-03f48c21d676
Closed

dotnet-maestro[bot] wants to merge 9 commits into
mainfrom
darc-main-824d2701-0e73-4e18-807f-03f48c21d676

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 11, 2025 •

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Updates:
    • From 7.0.0-preview.1.28 to 7.0.0-preview.1.46
      • Microsoft.Build.NuGetSdkResolver
      • NuGet.Build.Tasks
      • NuGet.Build.Tasks.Console
      • NuGet.Build.Tasks.Pack
      • NuGet.CommandLine.XPlat
      • NuGet.Commands
      • NuGet.Common
      • NuGet.Configuration
      • NuGet.Credentials
      • NuGet.DependencyResolver.Core
      • NuGet.Frameworks
      • NuGet.LibraryModel
      • NuGet.Localization
      • NuGet.Packaging
      • NuGet.ProjectModel
      • NuGet.Protocol
      • NuGet.Versioning

…7.0.0.31

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.31
dotnet-maestro Bot and others added 2 commits July 12, 2025 12:30
…7.0.0.36

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.36
@SimonZhao888

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro Bot and others added 2 commits July 15, 2025 12:24
…7.0.0.37

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.37
@nagilson nagilson added the Area-Containers Related to dotnet SDK containers functionality label Jul 15, 2025
@nagilson
nagilson enabled auto-merge July 15, 2025 16:53
@SimonZhao888

SimonZhao888 commented Jul 16, 2025 •

Copy link
Copy Markdown
Member

Test case Packing_a_netcoreapp_2_0_DotnetCliTool_app_includes_the_implicit_dependency() fails due to the following method does not modify the denpendency as in the main branch.

testProject.AdditionalProperties.Add("PackageType", "DotnetCliTool");

Main branch:
image
This PR:
image
So the test case will return an empty array at PackAndGetDependencies() method.
private List<XElement> PackAndGetDependencies(TestProject testProject, string identifier = null)
{
var dependencyGroups = GetDependencyGroups(PackAndGetNuspec(testProject, identifier), out var ns);
// There should be only one dependency group for these tests
dependencyGroups.Count().Should().Be(1);
// It should have the right element name
dependencyGroups.Single().Name.Should().Be(ns + "group");
var dependencies = dependencyGroups.Single().Elements(ns + "dependency").ToList();
return dependencies;
}

@nagilson, @MiYanni, could you please take a look at this?

…7.0.0.46

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.46
@baronfel

Copy link
Copy Markdown
Member

Thanks for the connection to this @jjonescz - I think this needs to be merged into the VMR codeflow PR in order for either of them to succeed.

@jjonescz

Copy link
Copy Markdown
Member

I've merged changes from this PR into #49740.

@nkolev92

Copy link
Copy Markdown
Contributor

Test case Packing_a_netcoreapp_2_0_DotnetCliTool_app_includes_the_implicit_dependency() fails due to the following method does not modify the denpendency as in the main branch.

testProject.AdditionalProperties.Add("PackageType", "DotnetCliTool");

Main branch:
image
This PR:
image
So the test case will return an empty array at PackAndGetDependencies() method.

private List<XElement> PackAndGetDependencies(TestProject testProject, string identifier = null)
{
var dependencyGroups = GetDependencyGroups(PackAndGetNuspec(testProject, identifier), out var ns);
// There should be only one dependency group for these tests
dependencyGroups.Count().Should().Be(1);
// It should have the right element name
dependencyGroups.Single().Name.Should().Be(ns + "group");
var dependencies = dependencyGroups.Single().Elements(ns + "dependency").ToList();
return dependencies;
}

@nagilson, @MiYanni, could you please take a look at this?

This is expected with the new pruning feature.

A direct package that can be pruned will be excluded out of the generated package.

I don't imagine the package needs to be referencing netcoreapp package is it?

So either adjust the expectation or just set RestoreEnablePackagePruning to false in that test.

@SimonZhao888
SimonZhao888 disabled auto-merge July 17, 2025 05:50
@SimonZhao888

Copy link
Copy Markdown
Member

Close this PR as all changes had been merged into #49740.

@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-824d2701-0e73-4e18-807f-03f48c21d676 branch July 17, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow Area-Containers Related to dotnet SDK containers functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants