[baronfel]

Fixes: NuGet/Home#14431

The VMR updated S.CL across the whole codebase, but that hasn't flowed back here yet (see #6482 for discussion), but now this is blocking SDK codeflow. So this is the S.CL changes only to unblock the rest of the product.

[nkolev92]

@baronfel I think you probably need to unpin https://github.com/NuGet/NuGet.Client/blob/dev/build/DotNetSdkTestVersions.txt#L2 to get the tests to work (assuming the problem Andy talked about is addressed)

[baronfel]

I need a bit of expertise here - the tests that are failing are failing because the NuGetSdkResolver (which is shipped in the SDK but possibly copied over for testing) can't load NuGet.Common 7.0.0.0, but I don't know if that dll is also being copied over, or if there's a real binary build break, or some other explanation.

[nkolev92]

This is where the copying is happening: https://github.com/NuGet/NuGet.Client/blob/c08c2c29435d9ae4a8b738096033cae175485c03/test/TestUtilities/Test.Utility/TestDotnetCLiUtility.cs

Not super clear to me without debugging whether the sdk resolver assembly is getting copied.
I'd expect it to be a patching problem to be honest.

[baronfel]

I'll come back to this tomorrow. I was able to run the tests locally and they seem to work for me, so I'm down to trying to diff my environment from the CI environment.

[baronfel]

Thanks for the merge! Do you know if this should trigger flow from NuGet.Client => VMR? I am expecting to see that, and then for flow from VMR=>SDK to happen to unblock dotnet/sdk#49740.

[jjonescz]

NuGet.Client flows directly to SDK as well - and it's already in a flow PR there: dotnet/sdk#49743