Repository navigation
JIT: Remove some small loop cloning quirks - #96552
Merged
Merged
Conversation
Also switch the "is old loop" quirk to use the BB flag. Removing the remaining quirks in loop cloning causes new loop cloning to kick in, with resulting large size diffs, so I will do those separately.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAlso switch the "is old loop" quirk to use the BB flag. Removing the remaining quirks in loop cloning causes new loop cloning to kick in, with resulting large size diffs, so I will do those separately.
|
jakobbotsch
marked this pull request as ready for review
January 5, 2024 16:34
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall Minor diffs. |
BruceForstall
approved these changes
Jan 5, 2024
15 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also switch the "is old loop" quirk to use the BB flag.
Removing the remaining quirks in loop cloning causes new loop cloning to kick in, with resulting large size diffs, so I will do those separately.