Activity

1. BruceForstall

   added

   area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

   User StoryA single user-facing feature. Can be grouped under an epic.A single user-facing feature. Can be grouped under an epic.

   on Oct 6, 2023
2. BruceForstall

   added this to the 9.0.0 milestone on Oct 6, 2023
4. BruceForstall

   self-assigned this

   on Oct 9, 2023
5. jakobbotsch commented on Dec 13, 2023

   

   jakobbotsch

   on Dec 13, 2023

   Last edited by jakobbotsch

   Member

   More actions

   With recent work we are close to having moved from the old lexical representation of loops to a more general graph-based one. Since I'll be out until New Year's, here's a more detailed list of work done and expected future work.

   • Remove duplicated dominator and DFS implementations
     • JIT: Factor SSA's DFS and profile synthesis's loop finding #95251
     • JIT: Generalize check for full interruptibility #95299 (remove a dependency on old dominators)
     • JIT: Factor SSA's dominator tree computation #95507
     • JIT: Switch morph DFS to use general DFS #95726
     • Currently the old dominators are still used by optSetBlockWeights and by optFindAndScaleGeneralLoopBlocks, but should be switchable to the new dominator implementation relatively easily.
     • optFindAndScaleGeneralLoopBlocks also depends on dense reachability sets; in common cases (where the flow graph does not have irreducible loops) we may be able to replace them by loop containment checks. Eventually we'd like all of this to be replaced by profile synthesis.
   • Port old loop-based optimizations to new representation
     • JIT: Port loop cloning to the new loop representation #95326
     • JIT: Port VN and loop hoisting to new loop representation #95589
     • JIT: Remove loop-related VN quirks #95729
     • JIT: Remove most loop-related hoisting quirks #95734
     • JIT: Port loop alignment to new loop representation #95836
     • Loop unrolling
       • This turns out to be hard if we also have to maintain the old loop table, so I am removing dependencies on the old loop table first; see below
   • Switch loop optimizations to run on newly recognized loops
     • Remove remaining dependencies on old loop table to avoid maintaining it
       • JIT: Invalidate loop table after unrolling and dominators after MarkLocalVars #95854
       • JIT: Reuse (new) loop-finding DFS tree in SSA #95809
       • JIT: Compute new dominators earlier and invalidate old dominators #95925
       • JIT: Port loop unrolling to new loop representation #96454
       • JIT: Remove loop unrolling quirks #96477
       • Remove loop cloning quirks
         • JIT: Remove some small loop cloning quirks #96552
         • JIT: Remove unnecessary lexical preconditions in loop cloning #96553
         • JIT: Remove BBJ_RETURN loop cloning quirk #96555
         • JIT: Remove IV analysis quirk in loop cloning #96563
       • JIT: Invalidate old loop table immediately #96613
     • JIT: Create preheaders on new loops and delete old loop canonicalization #96647
     • JIT: Canonicalize newly recognized loops #96751
     • JIT: Clone newly recognized loops #96754
     • JIT: Unroll newly recognized loops #96752
     • JIT: Hoist in newly recognized loops #96753
     • JIT: Align newly recognized loops #96756
     • JIT: Port loop compaction to new loop representation #96995
     • JIT: Compact newly recognized loops #97149
     • JIT: Remove some loop flags #97314
   • JIT: Factor reachability sets and base them on new DFS #96892
   • JIT: Delete old DFS and dominator implementations #96927
   • JIT: Remove old loop code #97232

   Some stats from the loop representation switch over some of our win-x64 collections:

   • 25.1% more hoisting in benchmarks.run_pgo, 5.7% more hoisting in realworld, 35.8% more hoisting in libraries_tests.run
   • 7.3% more cloned loops in benchmarks.run_pgo, 6.8% more cloned loops in realworld, 6.7% more cloned loops in libraries_tests.run
   • 5.0% (~700) more aligned loops aggregated over the collections

   ❤️React with ❤️3Reacted by Tanveer Badar, Christiaan Rakowski and Paulus Pärssinen

   🚀React with 🚀2Reacted by Tanveer Badar and Alexandre Mutel
6. JulieLeeMSFT

   added this to .NET Core CodeGenon Jun 5, 2024
7. JulieLeeMSFT

   moved this to Team User Stories in .NET Core CodeGenon Jun 5, 2024
8. JulieLeeMSFT commented on Jul 30, 2024

   

   JulieLeeMSFT

   on Jul 30, 2024

   Member

   More actions

   .NET9 work is complete. Closing.
9. JulieLeeMSFT commented on Jul 30, 2024

   

   JulieLeeMSFT

   on Jul 30, 2024

   Member

   More actions

   Will move the pushed-out items to .NET 10 user story during .NET 10 planning.
10. JulieLeeMSFT

    closed this as completedon Jul 30, 2024
11. github-project-automation

    moved this from Team User Stories to Done in .NET Core CodeGenon Jul 30, 2024
12. github-actions

    locked and limited conversation to collaborators on Aug 30, 2024