Repository navigation
Conversation
c2a5e90 to
7c3d4e4
Compare
dotnet-policy-service
Bot
added
the
community-contribution
Rebased onto b37852e; remote had a stale pr/ohos-tryrun tip, so the branch was force-with-lease updated after PR creation. In flight: N3/N4/N8/N9/N14 (N9 approved, awaiting merge).
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
| # OpenHarmony cross builds cannot run the FIFO probes; pin the two answers here | ||
| # (the remaining linux-family answers come from the code below). OHOS_NDK_HOME, | ||
| # which this initial-cache script can read, identifies the build. | ||
| if(DEFINED ENV{OHOS_NDK_HOME} AND NOT "$ENV{OHOS_NDK_HOME}" STREQUAL "") |
There was a problem hiding this comment.
Add this to platform probe below and use the established pattern of this file. That comment is unnecessary.
There was a problem hiding this comment.
Done — moved the OpenHarmony detection into the platform probe block and set the two cache values in the existing elseif chain, and dropped the comment. Rebased on current main; head is now fe9a4a1d020 (1 file, 5 insertions).
Note
This reply was drafted with AI assistance (agent tooling) under the author's direction.
Ported from the OpenHarmony runtime integration branch.
7c3d4e4 to
fe9a4a1
Compare
|
Both of these are unused, so I'm closing it in favor of #136147. @springmin, as asked before, instead of these tiny few liner PRs, it would be good to push substantial changes in batches so we can see real progress on initial port work, as we have the precedence set by other platform ports. |
|
Understood — and thanks for the pointer. #136147 removed both configs, so closing #136132 is the right call. I'll regroup the remaining runtime port work into substantial batches instead of individual small PRs:
The three PRs already open (#135839, #135840, #135866) are in review and I'll leave them as they are. Note This reply was drafted with AI assistance (agent tooling) under the author's direction. |
All those PRs are less than 10 liners and none of them are showing the error they are fixing. All those and whatever work is remaining on native side can be wrapped in a single PR. i.e. description should read "with these changes, dotnet(1) or corerun(1) passes these test suites on the device / VM" or a "hello world app works" etc. These little PRs seem like result of static analysis by confused AI. |
|
Done — consolidated into #136194 with device validation: hello world, child-process start, network-interface enumeration, and RSA/TLS through the OpenSSL shim on an OpenHarmony device. #135839, #135840, #135866 and #136187 are closed in its favor. Note This reply was drafted with AI assistance (agent tooling) under the author's direction. |
dotnet#136194 carries N3/N4/N7/N8/D with device validation. Closed dotnet#135839, dotnet#135840, dotnet#135866 and dotnet#136187 in its favor and replied to am11 on dotnet#136132. Runtime in flight: dotnet#136185, dotnet#136186, dotnet#136194; SDK: dotnet#56732, dotnet#56733.
OpenHarmony cross builds cannot run the FIFO probes, so pin the two
HAVE_BROKEN_FIFO_*cache answers when the build is identified as OpenHarmony(
OHOS_NDK_HOMEis set, which the initial-cache script can read). Otherlinux-family cross targets keep their own probe results.
Test
cmake -C eng/native/tryrun.cmake -DCMAKE_SYSTEM_NAME=OHOSwithOHOS_NDK_HOMEset pins both answers;-DCMAKE_SYSTEM_NAME=Linuxor unsetleaves them unset.
Note
This PR was authored with AI assistance (agent tooling) under the author's direction.