Skip to content

[ci-fix-net11] Fix HybridWebView InvokeJavaScriptAsync exception test failures on iOS, MacCatalyst, and Windows - #36938

Merged
kubaflo merged 1 commit into
dotnet:net11.0from
devanathan-vaithiyanathan:fix-36805
Jul 30, 2026
Merged

kubaflo merged 1 commit into
dotnet:net11.0from
devanathan-vaithiyanathan:fix-36805

Conversation

@devanathan-vaithiyanathan

@devanathan-vaithiyanathan devanathan-vaithiyanathan commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Issue Details

PR #35852 (revert of #32491) accidentally rolled back 3 test assertions that PR #35626 had correctly updated — resetting "InvokeJavaScriptAsync threw an exception:" back to "InvokeJavaScript threw an exception:", while the handler still produced InvokeJavaScriptAsync.

Description of Change

HybridWebViewTests_InvokeJavaScriptAsync.cs to match the exception message format set by the handler in HybridWebViewHandler.cs.

Issues Fixed

Fixes #36805

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36938

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36938"

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jul 30, 2026
@devanathan-vaithiyanathan devanathan-vaithiyanathan added do-not-merge Don't merge this PR community ✨ Community Contribution and removed partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 30, 2026
@devanathan-vaithiyanathan devanathan-vaithiyanathan changed the title [ci-fix-net11] Fix HybridWebView InvokeJavaScriptAsync exception test failures on iOS, MacCatalyst, and Windows [ci-fix-net11][WIP] Fix HybridWebView InvokeJavaScriptAsync exception test failures on iOS, MacCatalyst, and Windows Jul 30, 2026
@vishnumenon2684

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@vishnumenon2684 vishnumenon2684 changed the title [ci-fix-net11][WIP] Fix HybridWebView InvokeJavaScriptAsync exception test failures on iOS, MacCatalyst, and Windows [ci-fix-net11] Fix HybridWebView InvokeJavaScriptAsync exception test failures on iOS, MacCatalyst, and Windows Jul 30, 2026
@vishnumenon2684 vishnumenon2684 added partner/syncfusion Issues / PR's with Syncfusion collaboration and removed do-not-merge Don't merge this PR labels Jul 30, 2026
@vishnumenon2684
vishnumenon2684 marked this pull request as ready for review July 30, 2026 14:29
Copilot AI review requested due to automatic review settings July 30, 2026 14:29
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates HybridWebView device tests to align their expected exception message prefix with the current HybridWebViewHandler behavior (InvokeJavaScriptAsync threw an exception:), fixing CI failures on iOS, MacCatalyst, and Windows.

Changes:

  • Updated three assertion strings in HybridWebViewTests_InvokeJavaScriptAsync to expect InvokeJavaScriptAsync threw an exception: (matching the handler’s thrown message format).

@kubaflo
kubaflo merged commit 1e5cc54 into dotnet:net11.0 Jul 30, 2026
130 of 148 checks passed
@github-actions github-actions Bot added this to the .NET 11.0-preview7 milestone Jul 30, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 30, 2026

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 8f00ccc4 Deployed Jul 30, 2026 by devanathan-vaithiyanathan via conclusion #1038
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants