Repository navigation
[Inflight Regression] Revert - Refactor the HybridWebView and properly support complex parameters - #35852
Merged
kubaflo merged 1 commit intoJun 29, 2026
Conversation
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BagavathiPerumal
force-pushed
the
Revert-fix-32491
branch
from
June 12, 2026 11:18
55fe94b to
818ca0e
Compare
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BagavathiPerumal
force-pushed
the
Revert-fix-32491
branch
2 times, most recently
from
June 19, 2026 11:35
daaf6ae to
e5b8ab3
Compare
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BagavathiPerumal
force-pushed
the
Revert-fix-32491
branch
from
June 29, 2026 06:07
e5b8ab3 to
e31cf55
Compare
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vishnumenon2684
marked this pull request as ready for review
June 29, 2026 08:23
Merged
kubaflo
pushed a commit
that referenced
this pull request
Jul 30, 2026
… failures on iOS, MacCatalyst, and Windows (#36938) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details PR #35852 (revert of #32491) accidentally rolled back 3 test assertions that PR #35626 had correctly updated — resetting "InvokeJavaScriptAsync threw an exception:" back to "InvokeJavaScript threw an exception:", while the handler still produced InvokeJavaScriptAsync. ### Description of Change <!-- Enter description of the fix in this section --> HybridWebViewTests_InvokeJavaScriptAsync.cs to match the exception message format set by the handler in HybridWebViewHandler.cs. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #36805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This HybridWebView control device test fails in CI on Windows on the main branch. This PR #32491 is the reason for the failures, so the changes were reverted to fix them.
https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-maui-refs-heads-main-28431e8bf62f4d9384/Controls.DeviceTests-packaged/1/console.2d2bf4e4.log?helixlogtype=result&skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2026-06-03T11%3A03%3A44Z&ske=2026-06-03T12%3A03%3A44Z&sks=b&skv=2026-02-06&sv=2026-02-06&se=2026-06-03T12%3A03%3A44Z&sr=b&sp=rl&sig=R2uIyS%2FZT0tSRgP%2Bos%2F8sCNnewQxuzR%2FOxx2SXMA30Y%3D
Also, these code changes were already reverted in the SR8 branch.
PR link: #35824
Issues Fixed
Fixes #35696