Repository navigation
Create a single docker image for python? #13686
Description
Code improvement description
The docker and uv images are essentially the same, with only very minor differences:
https://github.com/dependabot/dependabot-core/blob/f746ee0f46732b48fd535088d6c81e7491888529/python/Dockerfile
https://github.com/dependabot/dependabot-core/blob/f746ee0f46732b48fd535088d6c81e7491888529/uv/Dockerfile
One difference in uv
Lines 204 to 205 in f746ee0
I understand that this separation allows the ecosystem docker build to evolve independently, but in practice it often results in duplicated changes such as #13321 and missed bug fixes such as in #13630.
Would it make sense to consolidate these into a single build?
For example, the Python ecosystem image could be built first and then used as the base for the uv ecosystem
Activity
yeikel commentedon Dec 2, 2025
@jeffwidman From what I can tell, you are the main author of the
pythondocker build. What do you think of this take?yeikel commentedon Dec 2, 2025
For clarity, I am not expecting the team to tackle this right now given the known capacity challenges. I can give it a go provided we agree that it is a good idea.
jeffwidman commentedon Dec 2, 2025
LOL, I filed pretty much this exact ticket on our internal issue tracker yesterday morning. So I clearly think it's a good idea.
We generally want to avoid tight coupling between ecosystems so I don't know if there should be a single parent docker image that both inherit from, or if
uvshould inherit frompython... I don't know the solution, just that what we've got is a problem.Additionally, the fact that the rust dockerfile is pretty much copy/pasted into both
pythonanduvresults in a bit of a mess as well.As you alluded to, the business has me focused elsewhere lately, so I don't have the capacity to personally be too involved, but I'm sure the team focused on core would be happy to review if you want to give it a go. I do think it's a good idea. 👍
markhallen commentedon Dec 4, 2025
@yeikel this was on my radar. If you want to raise a PR I will review it. Thanks
yeikel commentedon Dec 7, 2025
Thanks @markhallen
I took a closer look and I have a few notes/questions:
uvandpythonecosystems use slightly different helper codebases. The differences are small, but they exist. This potentially means that unless we align these two, it won't be possible to avoid the two buildsdependabot-core/uv/Dockerfile
Line 76 in c093035
pythonecosystem insideuv. For example, my understanding is thatuvandpoetryaren’t directly related, yet there’s poetry-related code as well as a dependency on it within theuvecosystem. Is that intentional?dependabot-core/uv/helpers/requirements.txt
Line 7 in c093035
yeikel commentedon Dec 10, 2025
I'll go ahead and assume that
poetryis not needed in theuvecosystem as the documentation states clearly thatpoetrysupport is under thepipecosystem@markhallen If you get a minute to confirm this, it'd help to accelerate any future review
markhallen commentedon Dec 11, 2025
Yes. This was not included intentionally.