Repository navigation
Conversation
Member
|
Thanks for the contribution, but I think it is a bit more complicated, as this fix would result in the robots walking in place after reaching there goal during e.g. initial positioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue where the Goalie would not cheer when a goal was scored.
Proposed changes
Removed a useless check in the main.dsd where, on goal, the position would be checked to either stand still or run the cheer test. Since the cheer test already tests if the robot is goalie and otherwise stands still, it is equivalent.
Related issues
#1096
Checklist
pixi run build