Skip to content

Pin version to grpcio in build-requirements.txt - #23735

Merged
tvalentyn merged 2 commits into
apache:masterfrom
AnandInguva:req-patch
Oct 20, 2022
Merged

tvalentyn merged 2 commits into
apache:masterfrom
AnandInguva:req-patch

Conversation

@AnandInguva

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecov Bot commented Oct 19, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #23735 (1da6133) into master (bfeb476) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23735      +/-   ##
==========================================
- Coverage   73.23%   73.22%   -0.01%     
==========================================
  Files         719      719              
  Lines       95962    95967       +5     
==========================================
- Hits        70277    70273       -4     
- Misses      24373    24382       +9     
  Partials     1312     1312              
Flag Coverage Δ
python 83.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/apache_beam/io/gcp/bigquery_schema_tools.py 77.55% <0.00%> (-6.54%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.08% <0.00%> (-0.17%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread sdks/python/build-requirements.txt Outdated
grpcio-tools==1.37.0
# TODO(https://github.com/apache/beam/issues/23734): the sdist for grpcio==1.50.0 is failing on GH workers
# pin grpcio to the previous version.
grpcio==1.49.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pick the same version for grpcio and grpcio-tools? (We should probably do it at the beginning...)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the consequence if the version between the both differ?

IIUC, grpcio-tools==1.37.0 has a requirement of grpcio>=1.37.0. I think having a version equal to or greater than grpcio-tools for grpcio would be fine.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this pinning for the mac platform only? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AnandInguva

Copy link
Copy Markdown
Contributor Author

R: @tvalentyn @TheNeuralBit

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn

Copy link
Copy Markdown
Contributor

LGTM

@tvalentyn

Copy link
Copy Markdown
Contributor

remaining tests should be not affected by this change.

@tvalentyn
tvalentyn merged commit 259cec0 into apache:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants