Skip to content

[Bug]: Py310 unittests on MacOS are failing #23734

Closed

Description

@AnandInguva

What happened?

Python 3.10 unit tests are failing on MacOS. Could be related to newer version of grpcio, transitive dependency of grpcio-tools released on October 18, 2022.
https://github.com/apache/beam/actions/runs/3278125487/jobs/5396167668

Issue Priority

Priority: 1

Issue Component

Component: test-failures

Activity

  1. AnandInguva commented on Oct 19, 2022

    @AnandInguva
    ContributorAuthor

    .add-labels "failing test"

  2. github-actions commented on Oct 19, 2022

    @github-actions
    Contributor

    Label "failing cannot be managed because it does not exist in the repo. Please check your spelling.

  3. AnandInguva commented on Oct 20, 2022

    @AnandInguva
    ContributorAuthor

    Partial fix: #23735 is to pin a version to grpcio only for MacOS. I was able to pass this locally but it fails on GH actiions.

  4. damccorm commented on Oct 20, 2022

    @damccorm
    Contributor

    @AnandInguva looks like it is now working with your fix on master - https://github.com/apache/beam/actions/runs/3286759714/jobs/5415213138

  5. AnandInguva commented on Oct 20, 2022

    @AnandInguva
    ContributorAuthor

    Yes, we can downgrade this to P2. But still, it doesn't explain why the sdist of grpcio is failing on MacOS.

    Is there a way to SSH into the GH workers and check why the sdist failing? @damccorm

  6. AnandInguva commented on Oct 20, 2022

    @AnandInguva
    ContributorAuthor

    .add-labels P2

  7. added and removed on Oct 20, 2022
  8. damccorm commented on Oct 20, 2022

    @damccorm
    Contributor

    Technically, yes - https://github.com/appleboy/ssh-action - but we can't add that action to the main beam repo because its a big security hole. If you want to go that route, I'd recommend doing it on a fork of the repo. You might be better off just scripting commands to run in your fork and checking them in as actions steps though

  9. AnandInguva commented on Oct 21, 2022

    @AnandInguva
    ContributorAuthor

    Thanks Danny. I will try to debug that way.

  10. AnandInguva commented on Apr 3, 2023

    @AnandInguva
    ContributorAuthor

    This has been solved in #24599.

  11. added this to the 2.47.0 Release milestone on Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions