Repository navigation
[bug] fix microVM actors with one character container names - #2801
Merged
Haven Xia (HavenXia) merged 1 commit intoOct 19, 2026
Merged
Haven Xia (HavenXia) merged 1 commit into
Haven Xia (HavenXia) merged 1 commit into
Conversation
kata rejects container IDs shorter than two characters, so derive the kata ID from the name instead of using the name as is this also stops the durable, csi and system-info volume shares from hiding the rootfs of a container with the same name
Benjamin Elder (BenTheElder)
added
area/microVM
breaking-change
Haven Xia (HavenXia)
approved these changes
Oct 19, 2026
Benjamin Elder (BenTheElder)
deleted the
microvm-short-container-names
branch
October 19, 2026 17:48
12 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicroVM actors with a one character container name never started: We used the name as the kata container ID, and kata rejects IDs shorter than two characters. gVisor and Kubernetes allow these names.
https://github.com/kata-containers/kata-containers/blob/4.1.0/src/libs/kata-sys-util/src/validate.rs#L17-L22
The kata ID is now
c_<name>. It only depends on the name, since a restored guest keeps the IDs it booted with.This won't hit any limits, and it can't conflict with container names.
It also fixes a collision risk for container named
durable+ durable dir volumes (doesn't exist for gvisor).I had an e2e test, but it seems unlikely we'll regress this and not worth the compute on every PR.
AI-assisted. Tested on kind (micro-VM and gVisor) and I reviewed the changes.
Breaking change: Like other pre-GA changes, you'll lose old snapshots. This should be small enough to land pre-GA.
Fixes #2800