You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 4, 2026. It is now read-only.
Onboarding process is tightly tied to AppDelegate, Sage and CoreData #24
This can be remedied by removing APCOnboarding.prepareScenes and letting its delegate supply the scenes/tasks it should perform. I'm in the process of getting this done, might run into other issues.
What I currently have is that APCOnboarding asks the app delegate for all the different predefined scenes. It then creates steps for all the scenes and can start the process with only the scenes I have implemented (still WiP).
There are still dependencies I don't like very much, some view controllers for example ask the app delegate for the current user when probably the user should be known to APCOnboarding. And some view controllers handle their own step logic, and other things like this.
My current idea is to encapsulate everything into APCOnboarding and then a new app can subclass it to make it work as desired. The app delegate will be asked to create an instance of the desired class, as is already the case. Then all onboarding view controllers get a handle to that instance and all logic decisions delegated to it instead of asking the app delegate all the time.
Activity
p2 commentedon Apr 30, 2015
This can be remedied by removing
APCOnboarding.prepareScenesand letting its delegate supply the scenes/tasks it should perform. I'm in the process of getting this done, might run into other issues.p2 commentedon May 4, 2015
I am working on cleaning this up on https://github.com/chb/AppCore/tree/develop/modularize_onboarding but it needs thorough refactoring in many areas.
jwe-apple commentedon May 4, 2015
@peculiar Could you have a look and recommend next steps? Thanks!
p2 commentedon May 4, 2015
What I currently have is that
APCOnboardingasks the app delegate for all the different predefined scenes. It then creates steps for all the scenes and can start the process with only the scenes I have implemented (still WiP).There are still dependencies I don't like very much, some view controllers for example ask the app delegate for the current user when probably the user should be known to
APCOnboarding. And some view controllers handle their own step logic, and other things like this.My current idea is to encapsulate everything into
APCOnboardingand then a new app can subclass it to make it work as desired. The app delegate will be asked to create an instance of the desired class, as is already the case. Then all onboarding view controllers get a handle to that instance and all logic decisions delegated to it instead of asking the app delegate all the time.Merge pull request ResearchKit#24 from EricSiegNW/feature/Bridge-663