#import "APCAppCore.h" where it's not necessary #16

Activity

1. p2 commented on Apr 30, 2015

   

   p2

   on Apr 30, 2015

   MemberAuthor

   More actions

   Also, would it be possible to replace

   [[UIStoryboard storyboardWithName:@"APCPasscode" bundle:[NSBundle appleCoreBundle]]
   

   with

   [[UIStoryboard storyboardWithName:@"APCPasscode" bundle:[NSBundle bundleForClass:[self class]]]
   

   I'm not sure why the storyboard is made dependent on a specific bundle key.
2. p2

   added a commit that references this issue on Apr 30, 2015

   Lighten AppCore dependency, remove double-define

   ...

   This issue will close once commit a33b444 is merged into the 'master' branch.

   a33b444
3. jwe-apple commented on Apr 30, 2015

   

   jwe-apple

   on Apr 30, 2015

   Member

   More actions

   Same - please submit as a PR and I'll have someone review it!
4. p2 commented on Apr 30, 2015

   

   p2

   on Apr 30, 2015

   MemberAuthor

   More actions

   I'm running into more of these as I integrate, happy to send a PR once I'm through.
5. p2

   added a commit that references this issue on Apr 30, 2015

   Lessen AppCore dependency, remove double-define

   ...

   This issue will close once commit 23db712 is merged into the 'master' branch.

   23db712
6. p2 commented on Apr 30, 2015

   

   p2

   on Apr 30, 2015

   MemberAuthor

   More actions

   A lot of the view controllers depend on APCAppDelegate. I have moved the methods accessed into a protocol that APCAppDelegate adopts, and my own app delegate as well. Since to get this to work on my end I have to follow this path throughout and I'm doing this while I'm removing all the AppCore.h imports.

   Should I or should I not commit this to this branch?

   The protocol currently is:

   @protocol APCAppDelegateTasks <NSObject>
   
   @required
   @property (copy, nonatomic, readonly) NSDictionary *__nullable initializationOptions;
   
   @property (strong, nonatomic, readonly) APCDataSubstrate *__nullable dataSubstrate;
   
   @property (strong, nonatomic, readonly) APCOnboarding *__nullable onboarding;
   
   - (void)instantiateOnboardingForType:(APCOnboardingTaskType)type;
   
   @end
7. jwe-apple commented on Apr 30, 2015

   

   jwe-apple

   on Apr 30, 2015

   Member

   More actions

   I'd lean toward getting the first PR accepted, then submitting it as a follow-on.
8. p2 commented on Apr 30, 2015

   

   p2

   on Apr 30, 2015

   MemberAuthor

   More actions

   I'll keep it piling up on my master branch, can later cherry-pick.
9. jwe-apple

   closed this as completedin 23db712on Apr 30, 2015
10. Erin-Mounts

    added a commit that references this issue on Sep 16, 2015

    Merge pull request ResearchKit#16 from EricSiegNW/feature/Bridge-735

    ...

    b989969