Repository navigation
ARAX hotfix: restore xCRG pin, NodeNorm/NameRes by maturity, blocklist fix - #2917
Merged
Merged
Conversation
…tion" This reverts commit a359220, reversing changes made to b359625. Decided on the 2026-10-09 call: the OTel integration is not part of this TEST/PROD hotfix. Resolving a merge conflict in #2895 also put the xCRG pin back to the old version (IC before NGD) and dropped Jonathan's pin from #2897. This revert restores requirements.txt to its state before #2895, which brings back the new xCRG pin. To bring the OTel work back later, revert this commit.
The maturity map still sent production to the old pre-ElasticSearch service (nodenorm.transltr.io/1.4). ITRB deployed NodeNorm ES to PROD on 2026-10-08, same version as nodenorm-es.test, so production now uses it. Development, staging and testing are unchanged, so CI and TEST behave the same as before. Adds test_node_normalizer_url_by_maturity, which checks the URL each maturity resolves to. (cherry picked from commit 8a5d641c3b49ca97485aa882b4dece9532096d10)
NAME_RESOLVER_URL was hardcoded to RENCI for every environment, so CI, TEST and PROD all called name-resolution-sri.renci.org. Add NAME_RESOLVER_URL_BY_MATURITY and resolve_name_resolver_url(), the same pattern as the NodeNorm map: development and staging use name-lookup.ci.transltr.io, testing uses name-lookup.test.transltr.io, production uses name-lookup.transltr.io. RENCI stays as the fallback when RTXConfiguration cannot be read. All three Translator hosts expose /bulk-lookup and accept the payload this module sends. Adds test_name_resolver_url_by_maturity.
edeutsch
approved these changes
Oct 9, 2026
Collaborator
Author
|
/deploy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
/deploy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
not43s
approved these changes
Oct 9, 2026
not43s
left a comment
not43s
left a comment
Collaborator
There was a problem hiding this comment.
If the deploys and tests are good then this looks fine to me.
…tant The query log printed NodeSynonymizer.NAME_RESOLVER_URL, the fallback, so every tier showed name-resolution-sri.renci.org even though NameRes now follows the maturity. Log resolve_name_resolver_url() instead, the same way the NodeNorm URL is logged.
Collaborator
Author
|
/redeploy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Preview pytestBuild: Container: pytest: 191 passed, 0 failed, 144 skipped in 181.39s (0:03:01) |
Preview live queriesBuild: Endpoint:
|
bazarkua
changed the title
ARAX preview🧹 ARAX preview for this PR was removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for the ITRB TEST deploy, as decided on the 10/9 call. It goes into master first, then master into
itrb-test. PROD gets the same code next Thursday.What is in it
requirements.txtandARAX_connect.pyto their state before Pathfinder otel integration #2895, so the new xCRG ranker is back. OTel is not part of this deploy; to bring it back later, revert the revert.nodenorm.transltr.io/1.4. It now usesnodenorm-es.transltr.io(deployed by ITRB on 10/8, same version as TEST). CI and TEST do not change.name-lookup.ci.transltr.io, testing usesname-lookup.test.transltr.io, production usesname-lookup.transltr.io. RENCI is only the fallback. The query log now shows the resolved NameRes URL.biolink:equivalent_identifiers,xref,same_as), so blocklisted concepts like "Prescribed medications" are removed again.Also comes with it, from master since the last TEST deploy on 9/16: the NGD speedup with the v1.1
curie_ngd/curie_to_pmidsdatabases (#2889, needed by the new xCRG), the SmartAPI dev Retriever entry (#2902, dev only), and CI / PR preview workflow updates. ChangeLog: #2874.Testing
On the preview (https://cicd.rtx.ai/2917/) with the maturity set to staging, testing and production:
*.ci,*.test, and the PROD hosts).