[R0Wi]

• Gracefully handle already done ocr

Throw OcrResultEmptyException if OCRmyPDF returns exit code 6 (ExitCode.already_done_ocr).
Fix of #293

• Update composer.lock to get latest OCP

• Update psalm baseline

• Introduce OcrAlreadyDoneException and add tests

• Add additional integration tests for new result code handling

---

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR adds support for gracefully handling OCR requests that have already been completed by introducing a dedicated exception, updating core services to catch it, and expanding test coverage.

• Introduce OcrAlreadyDoneException and throw it when exit code 6 is received
• Update OcrService to catch and handle the new exception under skip-file mode
• Add unit and integration tests to cover the new exception path and reset test baselines

Reviewed Changes

Copilot reviewed 16 out of 33 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
lib/Exception/OcrAlreadyDoneException.php	New exception class for already-done OCR
lib/Service/OcrService.php	Catch OcrAlreadyDoneException instead of empty-result exception
lib/OcrProcessors/Remote/WorkflowOcrRemoteProcessor.php	Throw OcrAlreadyDoneException on exit code 6
lib/OcrProcessors/Local/OcrMyPdfBasedProcessor.php	Throw OcrAlreadyDoneException on exit code 6
lib/OcrProcessors/OcrProcessorFactory.php	Register processors with updated handlers
tests/Unit/Service/OcrServiceTest.php	Update mock throws and add test for non-skip mode exception
tests/Unit/OcrProcessors/Remote/WorkflowOcrRemoteProcessorTest.php	Add test for exit-code-6 handling
tests/Unit/OcrProcessors/Local/PdfOcrProcessorTest.php	Add test for exit-code-6 handling in local processor
tests/Integration/OcrBackendServiceTest.php	Add integration test for skip-file behavior
tests/Integration/LocalBackendTest.php	Add integration tests for skip-file and skip-text modes
tests/Integration/IntegrationTestApiClient.php	Add reset() to clear test state
tests/Integration/BackendTestBase.php	Extend addOperation signature and clear operation cache
tests/psalm-baseline.xml	Remove obsolete Psalm entry

Comments suppressed due to low confidence (1)

tests/Integration/LocalBackendTest.php:119

• The assertion message says 'Expected no TextRecognizedEvent' but you are asserting a count of 1. Update the message to reflect that one event is expected.

		$this->assertEquals(1, count($this->capturedEvents), 'Expected no TextRecognizedEvent');

[Copilot]

[nitpick] Consider using $this->expectException(OcrAlreadyDoneException::class) at the start of this test instead of the manual try-catch and flag — it improves readability and aligns with other tests.

[Copilot]

The constructor overrides the exception message without calling parent::__construct($message). Consider calling the parent constructor to ensure proper exception initialization.

Suggested change

	$this->message = $message;
	parent::__construct($message);

[Copilot]

[nitpick] The debug log still references an 'empty OCR result', which could be misleading now that this is handling the 'already done' case. Consider updating the log message to mention the already-done scenario.

Suggested change

	$this->logger->debug('Skipping empty OCR result for file with id {fileId} because OCR mode is set to \'skip file\'', ['fileId' => $fileId]);
	$this->logger->debug('Skipping file with id {fileId} because OCR has already been performed and OCR mode is set to \'skip file\'', ['fileId' => $fileId]);