[XueSheng-GIT]

Throw OcrResultEmptyException if OCRmyPDF returns exit code 6 (ExitCode.already_done_ocr).
Fix of #293

@R0Wi:
Not sure whether existing check for empty file is still required for 'Local'? There's no such check for 'Remote'.

workflow_ocr/lib/OcrProcessors/Local/OcrMyPdfBasedProcessor.php

Lines 83 to 85 in 8fa36b4

	if (!$ocrFileContent) {
	throw new OcrResultEmptyException('OCRmyPDF did not produce any output for file ' . $file->getPath());
	}

Also not sure about the requirement for additional tests.

[R0Wi]

Thanks for this PR @XueSheng-GIT 👍 At a first glance, the code LGTM. I need to check why some of the tests are failing but I also encountered this Undefined constant OCP\IUser::MAX_USERID_LENGTH error locally. Might be a problem with the current Nextcloud master (NC32).

@R0Wi: Not sure whether existing check for empty file is still required for 'Local'? There's no such check for 'Remote'.

I don't think it was intended that I didn't add it to the "Remote"-implementation. As far as I remember this check was to ensure that we never overwrite the original PDF with an empty payload. Also this was slightly adjusted to cover #232. I would suggest leave it there for now, I'm working on a common base class for "Local" and "Remote" anyways so I will move it there

Also not sure about the requirement for additional tests.

Would be brilliant if you could provide 2 additional test cases. Let me know if you need help with the implementation of the PHPUnits

[XueSheng-GIT]

@R0Wi Undefined constant OCP\IUser::MAX_USERID_LENGTH could be related to nextcloud/server@1ada991.
To be honest, I didn't use XDebug so far. Thus, I'll first need to setup a local dev environment to dig deeper. At the moment I struggle a bit to find time. I don't mind if you can have a look at this issue. Otherwise I'll have a closer look sometime during the next weeks.

[R0Wi]

I can take a look into the tests, no problem. If you need a quick NC dev setup, I can recommend using the Nextcloud Devcontainer or directly run the IDE within Github Codespaces.

[R0Wi]

@R0Wi Undefined constant OCP\IUser::MAX_USERID_LENGTH could be related to nextcloud/server@1ada991.

@XueSheng-GIT you were right, I needed to update the OCP composer package to reflect the latest NC code changes. Otherwise it ran into conflicts with the function signature.

I added some tests and I'm trying to finalize those soon.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[R0Wi]

The backport to stable31 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable31 stable31
# Navigate to the new working tree
cd .worktrees/backport-stable31
# Create a new branch
git switch --create backport-308-to-stable31
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 10332e96f984fa643743daa9ea50ecbac28289af
# Push it to GitHub
git push --set-upstream origin backport-308-to-stable31
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable31

Then, create a pull request where the base branch is stable31 and the compare/head branch is backport-308-to-stable31.