Repository navigation
Add a 3D view beside the gradient explorer - #623
Open
dem-extra1 wants to merge 18 commits into
Open
dem-extra1 wants to merge 18 commits into
dem-extra1 wants to merge 18 commits into
Conversation
Closes #607 (all seven vector-calc contour figures; the interactive gradient explorer is out of scope there). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…to claude/project-thread-qgkfho
The contour-line example had no surface plot. The new figure draws the bowl with the circles at heights 1, 4 and 9 and the two example points. The tilt-a-plane figure already shows its plane in 3D, so it is marked no-3d. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The lint-changed-lines check flags nested calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The graph of the chosen function with the same point, level curve and arrows, drawn in a separate subfile that reads the explorer's cells. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It holds only OJS code, which lintr parses as R, as for the other OJS figures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Contributor
|
Claude finished review — View run I fetched PR mds#623 live. It is VerdictReady for merge My review above stands. Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "46ebc3f0db4688b8f60575e8e86a52900af208f4",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The commit 46ebc3f adds the gradient-explorer-3d subfile to the .lintr.R exclusions with the same Inf form as its siblings, and the path matches an existing file.",
"holistic_assessment": "The change is a one-line config addition with no prose or math, so there is no regression or scope concern beyond the unrendered page."
}Reviewed commit: 46ebc3f |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ezra asked for a 3D plot beside every contour or level-curve plot, and answered "daytb" to my recommendation for the gradient explorer: a 3D panel tied to its controls.
_fig-gradient-explorer-3d.qmd(new): the graph of the function chosen in the explorer, drawn in 3D with a hand-rolled d3 projection, as_fig-tilt-a-plane.qmddoes. It shows the chosen point lifted onto the surface, the level curve through it at constant height, and the red gradient and blue step-direction arrows, each rising by its change in f. It reads the explorer's cells, so the same sliders drive it, and has its own "turn the view" slider._sec_vector_calc.qmd: includes the new subfile right after the explorer.Checked by running the figure's cell under Node with d3 and jsdom for both functions: no NaN coordinates, no empty paths. I did not look at it in a browser. The page rendered to HTML locally.
Generated by Claude Code