Skip to content

Add a 3D view beside the gradient explorer - #623

Open
dem-extra1 wants to merge 18 commits into
mainfrom
claude/project-thread-qgkfho
Open

dem-extra1 wants to merge 18 commits into
mainfrom
claude/project-thread-qgkfho

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Ezra asked for a 3D plot beside every contour or level-curve plot, and answered "daytb" to my recommendation for the gradient explorer: a 3D panel tied to its controls.

  • _fig-gradient-explorer-3d.qmd (new): the graph of the function chosen in the explorer, drawn in 3D with a hand-rolled d3 projection, as _fig-tilt-a-plane.qmd does. It shows the chosen point lifted onto the surface, the level curve through it at constant height, and the red gradient and blue step-direction arrows, each rising by its change in f. It reads the explorer's cells, so the same sliders drive it, and has its own "turn the view" slider.
  • _sec_vector_calc.qmd: includes the new subfile right after the explorer.

Checked by running the figure's cell under Node with d3 and jsdom for both functions: no NaN coordinates, no empty paths. I did not look at it in a browser. The page rendered to HTML locally.



Generated by Claude Code

claude added 16 commits November 3, 2026 21:44
Closes #607 (all seven vector-calc contour figures; the interactive
gradient explorer is out of scope there).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The contour-line example had no surface plot. The new figure draws the
bowl with the circles at heights 1, 4 and 9 and the two example points.
The tilt-a-plane figure already shows its plane in 3D, so it is marked
no-3d.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The lint-changed-lines check flags nested calls.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The graph of the chosen function with the same point, level curve and arrows, drawn in a separate subfile that reads the explorer's cells.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

It holds only OJS code, which lintr parses as R, as for the other OJS figures.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR mds#623 live. It is OPEN, not a draft, and not merged (mergedAt is null). Its head is 46ebc3f0db4688b8f60575e8e86a52900af208f4, the commit I reviewed.

Verdict

Ready for merge

My review above stands. 46ebc3f adds one line to the .lintr.R exclusions and nothing else. The prior review also gave Ready for merge.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "46ebc3f0db4688b8f60575e8e86a52900af208f4",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The commit 46ebc3f adds the gradient-explorer-3d subfile to the .lintr.R exclusions with the same Inf form as its siblings, and the path matches an existing file.",
  "holistic_assessment": "The change is a one-line config addition with no prose or math, so there is no regression or scope concern beyond the unrendered page."
}

Reviewed commit: 46ebc3f

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2029 (review) — run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants