Skip to content

Add a 3D bowl figure beside the contour-line example - #622

Merged
dem-extra1 merged 13 commits into
mainfrom
claude/project-thread-qgkfho
Nov 4, 2026
Merged

dem-extra1 merged 13 commits into
mainfrom
claude/project-thread-qgkfho

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Ezra asked for a 3D plot beside every contour or level-curve plot (example). This covers the contour gaps that the new check-contour-3d caller (#619) does not report, because that check only looks at added lines.

  • _fig-contour-line-3d.qmd (new): the bowl g(b, c) = b^2 + c^2 as a surface, with the contour circles at heights 1, 4 and 9 and the two points of the example. R (plotly) and Python (matplotlib) tabs, as in the other 3D figures. It declares its own Python packages so a host site including it needs nothing extra.
  • _fig-tilt-a-plane.qmd: needs no change. It already draws the plane in 3D beside its contour map, and editing it would trip the one-div-per-subfile check.
  • Not covered: _fig-gradient-explorer.qmd, an interactive OJS explorer of a gradient at a point. A 3D surface there needs a Plotly widget wired to its sliders, which is a design choice for Ezra.

Rendered algebra-exponentials.qmd to HTML locally: the new figure is present and its references resolve.


🤖 Generated with Claude Code

https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz

claude added 11 commits November 3, 2026 21:44
Closes #607 (all seven vector-calc contour figures; the interactive
gradient explorer is out of scope there).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The contour-line example had no surface plot. The new figure draws the
bowl with the circles at heights 1, 4 and 9 and the two example points.
The tilt-a-plane figure already shows its plane in 3D, so it is marked
no-3d.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

The lint-changed-lines check flags nested calls.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #622 live with gh pr view. It is open, not a draft and not merged, and its head is 3cd35d59adc1fbdab953339c06cc654b4b9901ea. That is the commit I reviewed, so my review stands.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "3cd35d59adc1fbdab953339c06cc654b4b9901ea",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Commit 3cd35d5 splits the py_require call and the marks tibble into named intermediates in _fig-contour-line-3d.qmd; the values, chunk labels, figure id and fig-alt text are unchanged, so nothing breaks.",
  "holistic_assessment": "The refactor is scoped, follows the no-nested-calls rule, and introduces no regression risk or anchor changes; the page was not rendered, so the build is unverified."
}

Reviewed commit: 3cd35d5

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2217 (review) — run

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-04 02:28 UTC

@dem-extra1
dem-extra1 merged commit 84c4eb3 into main Nov 4, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants