Repository navigation
Add a 3D bowl figure beside the contour-line example - #622
Merged
Merged
Conversation
Closes #607 (all seven vector-calc contour figures; the interactive gradient explorer is out of scope there). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…to claude/project-thread-qgkfho
The contour-line example had no surface plot. The new figure draws the bowl with the circles at heights 1, 4 and 9 and the two example points. The tilt-a-plane figure already shows its plane in 3D, so it is marked no-3d. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The lint-changed-lines check flags nested calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Contributor
|
Claude finished review — View run I fetched PR #622 live with VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "3cd35d59adc1fbdab953339c06cc654b4b9901ea",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Commit 3cd35d5 splits the py_require call and the marks tibble into named intermediates in _fig-contour-line-3d.qmd; the values, chunk labels, figure id and fig-alt text are unchanged, so nothing breaks.",
"holistic_assessment": "The refactor is scoped, follows the no-nested-calls rule, and introduces no regression risk or anchor changes; the page was not rendered, so the build is unverified."
}Reviewed commit: 3cd35d5 |
Contributor
Contributor
2026-11-04 02:28 UTC |
dem-extra1
pushed a commit
that referenced
this pull request
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ezra asked for a 3D plot beside every contour or level-curve plot (example). This covers the contour gaps that the new check-contour-3d caller (#619) does not report, because that check only looks at added lines.
_fig-contour-line-3d.qmd(new): the bowl g(b, c) = b^2 + c^2 as a surface, with the contour circles at heights 1, 4 and 9 and the two points of the example. R (plotly) and Python (matplotlib) tabs, as in the other 3D figures. It declares its own Python packages so a host site including it needs nothing extra._fig-tilt-a-plane.qmd: needs no change. It already draws the plane in 3D beside its contour map, and editing it would trip the one-div-per-subfile check._fig-gradient-explorer.qmd, an interactive OJS explorer of a gradient at a point. A 3D surface there needs a Plotly widget wired to its sliders, which is a design choice for Ezra.Rendered
algebra-exponentials.qmdto HTML locally: the new figure is present and its references resolve.🤖 Generated with Claude Code
https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz