Skip to content

(janitor/dependencies): patch hono and webpack-dev-middleware vulnerabilities - #7083

Open
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor-deps
Open

kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor-deps

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Changes

Runtime / Workers (shared catalog + override)

  • hono 4.13.5 -> 4.13.7 (catalog entry and override in pnpm-workspace.yaml)

Storybook / dev tooling (override)

  • webpack-dev-middleware 6.1.3 -> 7.4.6 via new override webpack-dev-middleware@^6: 7.4.6 (pulled in by @storybook/builder-webpack5 8.5.8 and 10.4.6). Adds transitive memfs@4.79.0 and @jsonjoy.com/* packages only.

Addressed alerts

Unresolved

Compatibility / overrides

  • 7.4.6 is the smallest fix for the 6.x line (no 6.x patch exists). Storybook builders declare ^6.1.3, so this is an out-of-range override; dev-only (never shipped). 7.x needs Node >= 18.12; repo uses Node 24. Remove the override once Storybook ships a builder on >= 7.4.6.
  • Both versions are older than the minimum release age; no exclusions added. No lockfile hand edits; lockfile diff contains only hono, webpack-dev-middleware and its new transitive deps.

Validation

  • pnpm install --lockfile-only (pnpm 11.1.2): OK; lock contains only hono 4.13.7 and webpack-dev-middleware 7.4.6
  • pnpm install --frozen-lockfile: OK
  • apps/storybook: pnpm build-storybook: succeeded
  • packages/worker-utils: pnpm typecheck OK; pnpm test: 788 passed
  • services/db-proxy, services/notifications: pnpm typecheck OK
  • git diff --check: clean; no conflict markers. prettier --check pnpm-workspace.yaml warns, but it does on main too.
  • Not run: Storybook dev server (exercises the middleware at runtime), full repo lint/tests, anything needing PostgreSQL/Redis. Node 22 in this environment vs. repo's Node 24 (engine warning).

@kilo-code-bot kilo-code-bot Bot added the janitor Automated dead-code/duplication cleanup label Oct 2, 2026
@socket-security

socket-security Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​hono@​4.13.5 ⏵ 4.13.7100 +1100 +297 +195 -1100

View full report

@kilo-code-bot

kilo-code-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Full review at head 0d003d05ee06ea98816ca60096e4268d1bbd9232 against base f146e14339a1d769e88fad85b788e60c797e857a. The previous SHA 646e47d3 is no longer reachable after the rebase, so this is a full re-review rather than an incremental diff.

  • hono 4.13.5 -> 4.13.7 is consistently applied in the catalog, overrides, every importer specifier, and all peer-resolution keys in the lockfile; no 4.13.5 residue remains.
  • New webpack-dev-middleware@^6: 7.4.6 override resolves all three Storybook 8.5.8/10.4.6 webpack5 builder references to a single 7.4.6 snapshot; no 6.x or 8.x snapshots remain, so the advisory range is fully covered.
  • The added transitive set (memfs 4.80.0, @jsonjoy.com/*, tree-dump, thingies, hyperdyperid, glob-to-regex.js) is what v7 requires; the lockfile diff contains no unrelated version changes and no install scripts.
  • v7's engines.node >= 18.12.0 is satisfied by the repo's Node 24, and 7.4.6 keeps webpack ^5.0.0 as an optional peer, matching the pinned webpack 5.105.4.

Not assessed: CI check status and the claimed Storybook build/typecheck runs were not re-executed in this read-only review. The unresolved node-forge alert is out of scope for this diff.

Files Reviewed (2 files)
  • pnpm-workspace.yaml
  • pnpm-lock.yaml - reviewed for consistency only (generated file)
Previous Review Summary (commit 646e47d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 646e47d)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • pnpm-workspace.yaml
  • pnpm-lock.yaml

Reviewed by deepseek-v4.1-flash-1017 · Input: 40.5K · Output: 4.6K · Cached: 386K

Review guidance: REVIEW.md from base branch main

@eshurakov eshurakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Independently reviewed the full dependency diff at head 646e47d against base 3de933d; no major security, compatibility, or manifest/lockfile issues found.

Verified both targeted advisories against upstream fixes. A read-only regression check using upstream middleware source reproduces traversal on 6.1.3 and confirms 7.4.6 rejects plain/encoded traversal while serving legitimate assets. This resolves the contradiction between advisory prose and its patched-version metadata. Storybook 8/10 use compatible middleware APIs; Node 24 satisfies the v7 engine requirement. Catalog/overrides and lockfile references are consistent; all 27 added package resolutions match npm integrity metadata, have no install-time lifecycle scripts, and return no current npm advisories. The unresolved node-forge alert still has no patched version.

CI caveat: cloud-agent-next fails because its Cloudflare test worker exits unexpectedly (5906 unit tests passed; 584/589 Workers tests completed). This is not evidence of a dependency regression, but neither is it a fully green run. Resolve the currently reported merge conflicts and obtain green CI before merging. No installs, workspace changes, or full Storybook dev-server smoke test performed.

Files Reviewed (2 files)
  • pnpm-workspace.yaml
  • pnpm-lock.yaml

Copy link
Copy Markdown
Contributor

Rebased onto freshly fetched main f146e14339a1d769e88fad85b788e60c797e857a and resolved dependency conflicts without downgrading newer main security updates. Head: 646e47d3d649ae44eee96a44b7538dbbb6a15e01 -> 0d003d05ee06ea98816ca60096e4268d1bbd9232 (one commit, exact SHA-pinned force-with-lease).

Scope remains Hono catalog/override 4.13.7 and webpack-dev-middleware@^6 override 7.4.6. Lockfile regenerated from main using declared pnpm 11.1.2 with lifecycle scripts disabled; middleware transitives now resolve memfs 4.80.0 rather than the original 4.79.0 under the existing release-age policy. All other existing package integrity hashes and workspace configuration were verified preserved.

Passed: targeted pnpm format, frozen/offline lockfile-only validation, exact manifest-scope/package-integrity assertions, conflict-marker check, git diff --check, clean worktree and remote-head verification. Initial resolver attempt exceeded default 2GB heap; bounded retry with 4GB heap succeeded. pnpm automatic dependency verification triggered an unintended install attempt that was stopped at timeout; subsequent formatting explicitly disabled that auto-install behavior. No full dependency install, runtime suites, builds, or repository-wide tests claimed.

Historical cloud-agent-next run 36967973615/job 110716805450: unit tests 5906 passed; integration reported 39/40 files and 584/589 tests passed, then Cloudflare Vitest pool worker exited unexpectedly with one unhandled pool error. No assertion failure established and no speculative production change made. Fresh-head CI will supersede that old run; merge remains gated on required checks. Overlapping #7562 was coordinated but not edited. No PR merged or closed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

janitor Automated dead-code/duplication cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant