Repository navigation
(janitor/dependencies): patch hono and webpack-dev-middleware vulnerabilities - #7083
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Full review at head
Not assessed: CI check status and the claimed Storybook build/typecheck runs were not re-executed in this read-only review. The unresolved Files Reviewed (2 files)
Previous Review Summary (commit 646e47d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 646e47d)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 40.5K · Output: 4.6K · Cached: 386K Review guidance: REVIEW.md from base branch |
eshurakov
left a comment
There was a problem hiding this comment.
Code Review Summary
Status: No Issues Found | Recommendation: Merge
Executive Summary
Independently reviewed the full dependency diff at head 646e47d against base 3de933d; no major security, compatibility, or manifest/lockfile issues found.
Verified both targeted advisories against upstream fixes. A read-only regression check using upstream middleware source reproduces traversal on 6.1.3 and confirms 7.4.6 rejects plain/encoded traversal while serving legitimate assets. This resolves the contradiction between advisory prose and its patched-version metadata. Storybook 8/10 use compatible middleware APIs; Node 24 satisfies the v7 engine requirement. Catalog/overrides and lockfile references are consistent; all 27 added package resolutions match npm integrity metadata, have no install-time lifecycle scripts, and return no current npm advisories. The unresolved node-forge alert still has no patched version.
CI caveat: cloud-agent-next fails because its Cloudflare test worker exits unexpectedly (5906 unit tests passed; 584/589 Workers tests completed). This is not evidence of a dependency regression, but neither is it a fully green run. Resolve the currently reported merge conflicts and obtain green CI before merging. No installs, workspace changes, or full Storybook dev-server smoke test performed.
Files Reviewed (2 files)
pnpm-workspace.yamlpnpm-lock.yaml
646e47d to
0d003d0
Compare
|
Rebased onto freshly fetched main Scope remains Hono catalog/override 4.13.7 and webpack-dev-middleware@^6 override 7.4.6. Lockfile regenerated from main using declared pnpm 11.1.2 with lifecycle scripts disabled; middleware transitives now resolve memfs 4.80.0 rather than the original 4.79.0 under the existing release-age policy. All other existing package integrity hashes and workspace configuration were verified preserved. Passed: targeted pnpm format, frozen/offline lockfile-only validation, exact manifest-scope/package-integrity assertions, conflict-marker check, git diff --check, clean worktree and remote-head verification. Initial resolver attempt exceeded default 2GB heap; bounded retry with 4GB heap succeeded. pnpm automatic dependency verification triggered an unintended install attempt that was stopped at timeout; subsequent formatting explicitly disabled that auto-install behavior. No full dependency install, runtime suites, builds, or repository-wide tests claimed. Historical cloud-agent-next run 36967973615/job 110716805450: unit tests 5906 passed; integration reported 39/40 files and 584/589 tests passed, then Cloudflare Vitest pool worker exited unexpectedly with one unhandled pool error. No assertion failure established and no speculative production change made. Fresh-head CI will supersede that old run; merge remains gated on required checks. Overlapping #7562 was coordinated but not edited. No PR merged or closed. |
Changes
Runtime / Workers (shared catalog + override)
hono4.13.5 -> 4.13.7 (catalog entry and override inpnpm-workspace.yaml)Storybook / dev tooling (override)
webpack-dev-middleware6.1.3 -> 7.4.6 via new overridewebpack-dev-middleware@^6: 7.4.6(pulled in by@storybook/builder-webpack58.5.8 and 10.4.6). Adds transitivememfs@4.79.0and@jsonjoy.com/*packages only.Addressed alerts
Unresolved
Compatibility / overrides
^6.1.3, so this is an out-of-range override; dev-only (never shipped). 7.x needs Node >= 18.12; repo uses Node 24. Remove the override once Storybook ships a builder on >= 7.4.6.Validation
pnpm install --lockfile-only(pnpm 11.1.2): OK; lock contains only hono 4.13.7 and webpack-dev-middleware 7.4.6pnpm install --frozen-lockfile: OKapps/storybook:pnpm build-storybook: succeededpackages/worker-utils:pnpm typecheckOK;pnpm test: 788 passedservices/db-proxy,services/notifications:pnpm typecheckOKgit diff --check: clean; no conflict markers.prettier --check pnpm-workspace.yamlwarns, but it does on main too.