Repository navigation
Conversation
Add activity-token registration and background delivery so eligible work updates the iOS Live Activity, Android ongoing notification, and Home widgets without opening the app. Logout unregisters tokens. Old clients ignore the new payload type.
This was referenced Aug 27, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryLive Activity start alerts now take caller-resolved, locale-aware copy from iOS Expo token rows; no new high-confidence issues. Files Reviewed (5 files)
Previous Review Summaries (19 snapshots, latest commit cc3fb2d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit cc3fb2d)Status: No Issues Found | Recommendation: Merge Executive SummaryThe glanceable-delivery test now asserts the concurrent personal/org scope set rather than completion order; no new high-confidence issues. Files Reviewed (1 file)
Previous review (commit 87f2be0)Status: No Issues Found | Recommendation: Merge Executive SummaryAPNs start alerts, Live Activity switch token cleanup, and lost-org-only publication latching look correct; no new high-confidence issues. Files Reviewed (12 files)
Previous review (commit 70b84a1)Status: No Issues Found | Recommendation: Merge Executive SummaryAndroid widget stale snapshots now draw counts without the delayed-warning line, matching the iOS card; no new high-confidence issues. Files Reviewed (3 files)
Previous review (commit 97c7ead)Status: No Issues Found | Recommendation: Merge Executive SummarySession-ingest tokens now use Files Reviewed (2 files)
Previous review (commit a7e6b31)Status: No Issues Found | Recommendation: Merge Executive SummaryAndroid widget iOS-card layout, headless language apply, lazy widget-task load, and work-runtime alignment look correct; no new high-confidence issues in the incremental diff. Files Reviewed (14 files)
Previous review (commit de0d279)Status: No Issues Found | Recommendation: Merge Executive SummaryAndroid widget cell-size layout, headless Files Reviewed (9 files)
Previous review (commit 007225c)Status: No Issues Found | Recommendation: Merge Executive SummaryAndroid glanceable surfaces now match iOS layout, Live Update settings, and localized widget-picker copy; no new high-confidence issues in the incremental diff. Files Reviewed (101 files)
Previous review (commit 8d324e1)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryHeadless glanceable pushes can restart the Live Activity because the in-app switch never hydrates from SecureStore outside the React auth tree. Overview
Issue Details (click to expand)WARNING
Files Reviewed (106 files)
Fix these issues in Kilo Cloud Previous review (commit 590a349)Status: No Issues Found | Recommendation: Merge Executive SummaryWidget and Live Activity layouts now map baked locale digits onto raw counts so non-Latin numbering matches SwiftUI waits; English still skips the table. Files Reviewed (4 files)
Previous review (commit a22fc31)Status: No Issues Found | Recommendation: Merge Executive SummarySession-ingest glanceable tests now expect Files Reviewed (2 files)
Previous review (commit 6c998ce)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental widget-gallery localization, privacy-copy, locale-underscore, and Hermes Files Reviewed (99 files)
Previous review (commit b526537)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (48 files)
Fix these issues in Kilo Cloud Previous review (commit d94ad7b)Status: No Issues Found | Recommendation: Merge Executive SummaryGlanceable surfaces now rank needs-input, working, and idle from a shared snapshot; widget writes omit nulls, and the Files Reviewed (126 files)
Previous review (commit 6f9b484)Status: No Issues Found | Recommendation: Merge Executive SummaryAPNs team ID, key ID, and private-key Secrets Store binding are now declared on the notifications worker; remaining changes are docs, generated types, and import formatting. Files Reviewed (5 files)
Previous review (commit 33674ef)Status: No Issues Found | Recommendation: Merge Executive SummaryActive Agents master switch blanks surfaces and drops headless snapshots when off; APNs topic is declared in worker vars. Files Reviewed (21 files)
Previous review (commit 421a090)Status: No Issues Found | Recommendation: Merge Executive SummaryCredential-shaped glanceable-refresh error fixture was replaced with a generic string; the test still asserts queue ack and logs only the session id. Files Reviewed (1 file)
Previous review (commit cee6acb)Status: No Issues Found | Recommendation: Merge Executive SummaryTerminal Live Activity ends now retire APNs targets under a generation fence before fresh work can start, with failed refresh isolated from queue ack. Files Reviewed (6 files)
Previous review (commit 35cf697)Status: No Issues Found | Recommendation: Merge Executive SummaryCommitted Cloud Agent run reports now refresh glanceable counts after the report transaction, with failed refresh isolated so the queue still acks. Files Reviewed (3 files)
Previous review (commit 7428272)Status: No Issues Found | Recommendation: Merge Executive SummaryGeneration-fenced glanceable refresh now runs from session metadata, heartbeat, and disconnect transitions, with APNs timestamp ordering and Expo supersession checks covering the concurrent-delivery races. Files Reviewed (18 files)
[Snapshot truncated.] Additional previous summary content was truncated to keep this comment within platform limits. Reviewed by grok-4.6 · Input: 133.9K · Output: 6.9K · Cached: 360.7K Review guidance: REVIEW.md from base branch |
…activities-3cf8-s4
…activities-3cf8-s4 # Conflicts: # apps/mobile/src/lib/auth/logout-cleanup.ts # apps/mobile/src/lib/notifications.test.ts # apps/mobile/src/lib/notifications.ts # packages/db/src/migrations/meta/0233_snapshot.json # packages/db/src/migrations/meta/_journal.json
…activities-3cf8-s4
…activities-3cf8-s4
…activities-3cf8-s4
…activities-3cf8-s4
The Android widget drew three identical grey rows of text. It carried none of the state vocabulary the iOS surfaces settled on, no mark, English-only picker copy, and no way to turn the Live Update off inside the app. Each row now leads with its state: filled orange for needs-input, filled green for working, an outline ring for idle. The shapes differ as well as the colors, so the three states stay apart for a user who cannot tell orange from green. The colors come from the app's own palette rather than a widget-local one — a Home Screen card that does not match the app it opens reads as a different product — and the Kilo mark sits beside them. Three sizes: a narrow cell shows the ranked count, a short one runs the states in a row, a tall one stacks them under the mark. The default placement is now 4x2 so the layout that shows all three states is the one a user gets. Counts are drawn in the language's own digits. Unlike the iOS widget extension these surfaces render in the app's own runtime, so `Intl` is already there and the formatter is injected rather than baked into a layout. The widget picker is translated into all 87 languages. The library already wraps the description in a string resource and writes the label straight into the receiver, so the label becomes a resource reference and a new plugin writes both keys into one `values-b+<tag>` folder per language. The copy comes from widget-gallery-copy.json, the file the iOS gallery already reads, so the two pickers cannot drift. The notifications screen's Live Activity row is now on both platforms, named the way each OS names the surface: a Live Activity on iOS, a Live Update on Android. Android reads the notification permission as its system state and leaves the Open Settings button to the master gate directly below, which enables the same permission. Turning the switch off ends the Live Update already in the shade. The widget is deliberately not gated: placing one is the opt-in and removing it is the opt-out.
The widget library writes it as translatable="false", which aapt2 reads as a promise that no values-<tag> override exists. The 86 the localization plugin writes are exactly that.
expo-modules-core's AppContext exposes only the React context, so appContext.applicationContext never resolved and the module failed to compile. Every entry point here runs from a JS call, so a lost React context means the module cannot work at all. The Android native build had never run: the workflow gate skipped it on every dispatch because an artifact for the unchanged native hash already existed.
A placed widget reports its cell in dp, and the two bucket thresholds were too tight: a 2x1 cell reported about 150-190 dp and took the three-state row, which clipped the last state, and a 4x1 cell reported up to about 110 dp and took the stacked layout, which clipped the last row. Move the splits between the real buckets and let a short row keep the label only on the ranked state. Also register the widget task handler from the app entry. Android redraws a placed widget from a headless JS task with no Activity, so an expo-router route never evaluates and the handler was never registered.
A widget redraw runs as a headless JS task with no Activity, so the app root that applies the language never mounts and the placed card rendered English whatever the user picked. Resolve the stored preference in the widget task itself, which needs an awaitable read on the preference store. Mirror the layout for a right-to-left language too. The widget library's flex engine has no reading direction, so each row reverses its own children and each column flips its alignment.
expo-widgets pulls androidx.glance, which depends on work-runtime-ktx 2.7.1, while react-native-android-widget depends on work-runtime 2.8.1. Version 2.8.0 folded the ktx classes into the main artifact, so the two together fail :app:checkDebugDuplicateClasses. Pin both to 2.8.1, where ktx is an empty shim.
The app entry registered the headless widget task by importing the whole Android glanceable slice, which starts i18n and SecureStore before expo-router sets the app up. Register a thin handler instead and require the slice from inside it, so the entry touches one module.
Drop the "Open agents" line: the whole card already opens the agents screen, so the words only took the space the counts needed. Move the stale warning under the mark, above the rows. A fourth line below three counts read as a fourth state. Draw every state, zeros included, so the rows hold still as work moves between them. Stack the rows whenever the cell is tall enough, however narrow it is. Beside the mark a two-cell-wide card truncated its labels.
…activities-3cf8-s4 # Conflicts: # apps/web/src/routers/active-sessions-router.ts
The iOS card draws its counts and no warning when the data is stale, so the Android card now does the same. The line cost the rows their width and read as a fourth state. The ongoing notification still says the counts are delayed.
eshurakov
approved these changes
Sep 3, 2026
…activities-3cf8-s4
Apple rejects a Live Activity start payload that carries no alert. Only Apple Watch renders its title and body; the phone shows the activity. Claude-Session: https://claude.ai/code/session_01MHf6WEQu5qVG8yYN7g2G3Y
Turning Live Activities off ended the activity but kept the push-to-start subscription, so a remote start still reopened the surface. The switch now retires that token and blocks every re-registration of it while it is off. The FIFO token-mutation queue moves to its own module. It shares no state with the rest of the file, which sat on the max-lines limit. No behavior change. Claude-Session: https://claude.ai/code/session_01MHf6WEQu5qVG8yYN7g2G3Y
143 Gradle and Kotlin build artifacts entered the tree with the Live Update module fix. `apps/mobile/.gitignore` already ignores the directory. Claude-Session: https://claude.ai/code/session_01MHf6WEQu5qVG8yYN7g2G3Y
…activities-3cf8-s4
`refreshGlanceableSessions` fans the personal and organization scopes out with `Promise.allSettled`, so the order the snapshot route observes them in is scheduling-dependent. The exact-array assertion failed on CI. Claude-Session: https://claude.ai/code/session_01MHf6WEQu5qVG8yYN7g2G3Y
The push-to-start alert was hardcoded English. `generic.title` and `generic.body.activeAgentsGlanceable` already exist in all 87 push catalogs, so no new copy is needed. `user_activity_tokens` carries no locale, but the same delivery already reads the iOS Expo rows, which do. Read them first and resolve the alert from the first row that has one; an absent locale falls back to English. `apns-live-activity` takes the resolved alert and stays a pure transport. Claude-Session: https://claude.ai/code/session_01MHf6WEQu5qVG8yYN7g2G3Y
lambertjosh
added a commit
to Kilo-Org/kilocode
that referenced
this pull request
Sep 14, 2026
Account for #14101 and #13951 after the original sync. Verify notification channels against #13771 and widget layouts against Kilo-Org/cloud#5620. Clarify partial change summaries from cloud#5810 and remove implementation-heavy prose.
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS app now keeps the Active Agents Live Activity and the Lock Screen and Home Screen widgets current while the app is backgrounded or closed. They show how many agents are running, need input, or are reconnecting, a status line such as "No work in progress", and how long eligible work has run.
The Android Active Agents notification now updates in the background instead of only while the app is open.
If the device cannot show Live Activities, the Agents tab shows a one-time prompt to open Settings and enable them.
Signing out now also removes the device's background-update registration, so the signed-out account stops updating the Live Activity and widgets.
Reviewer Notes
A
user_activity_tokenstable stores device activity tokens for the glanceable surfaces. It holds the iOS push-to-start, iOS activity, and Android ongoing tokens, keyed by user and an optional organization, with a unique constraint on the token and cascade deletion with the user. Account soft-delete now also deletes these rows so a deleted user stops receiving glanceable deliveries.Files
packages/db/src/schema.ts— adds theuser_activity_tokenstable, its unique token index, and its user-plus-organization index.packages/db/src/migrations/0233_square_daimon_hellstrom.sql— creates the table, the user foreign key, and both indexes.apps/web/src/lib/user/index.ts— deletes the user's activity-token rows in the soft-delete path.Two new user mutations register and unregister activity tokens.
registerActivityTokenupserts on the token so a re-registration replaces the row, andunregisterActivityTokendeletes only a row owned by the caller.Files
apps/web/src/routers/user-router.ts— addsregisterActivityTokenandunregisterActivityTokenand imports the new table.The active-sessions core moves into a reusable server function. The tRPC procedure now delegates to
listActiveSessions, which keeps the worker fetch, the enrichment, and the cloud-agent merge, so the snapshot builder can reuse it without a tRPC context.Files
apps/web/src/lib/active-sessions-list.ts— new module holding the fetch, parse, enrich, and cloud-merge logic.apps/web/src/routers/active-sessions-router.ts— thelistprocedure now callslistActiveSessionsand re-exports its types.A new internal route builds the privacy-minimal glanceable snapshot for a user. It requires the internal secret, re-checks organization membership when an organization is named, and returns the same versioned shape the mobile publisher derives locally. The builder reads only each session's status, so titles, ids, and other raw fields never leave the server.
Files
apps/web/src/app/api/internal/glanceable-agents-snapshot/route.ts— the secret-authenticated route with the organization re-check.apps/web/src/lib/glanceable-agents-snapshot-server.ts— builds the snapshot from the active-sessions list through the shared builder.A new push data variant
active_agents_glanceablecarries the aggregate snapshot. It has a versioned revision, an opaque scope key, counts, status, and safe timestamps, and never a title or id. A newactive-agentsAndroid channel and count-free generic copy route this payload.Files
packages/notifications/src/push-data.ts— adds the variant and theGlanceableLiveActivityContentStatetype.packages/notifications/src/push-presentation.ts— adds the channel and the routing and generic-copy cases.packages/notifications/src/locales/en.json— adds the generic body string for the glanceable push.The notifications worker now sends Live Activity APNs pushes and aggregate glanceable deliveries. A token-based APNs client signs a provider JWT and sends start or update pushes, and a pure orchestrator builds the snapshot and pushes it to iOS activity tokens and Expo tokens. After each cloud-agent session push, the worker delivers the fresh snapshot best-effort.
Files
services/notifications/src/lib/apns-live-activity.ts— new APNs client with JWT signing, request building, and parallel sending.services/notifications/src/lib/glanceable-delivery.ts— new orchestrator whose IO is injected for tests.services/notifications/src/index.ts— wires the dependencies, reads the credentials, and delivers after the session push.The worker gains optional configuration for the snapshot and APNs delivery.
KILO_WEB_API_BASE_URLnames the web origin, and the four APNs values name the signing key and the topic. A missing value skips that part of delivery instead of failing the push.Files
services/notifications/src/bindings.d.ts— declares the new optional bindings.services/notifications/wrangler.jsonc— setsKILO_WEB_API_BASE_URLto the production origin.ENVIRONMENT.md— documents the five new values.The mobile app applies
active_agents_glanceablepushes in the foreground and in a headless background task. A scope-key fence and anupdatedAtcheck discard stale or foreign pushes, and the applied snapshot rebases its revision onto the local sequence and its local account epoch. The foreground handler suppresses these pushes as banners, and taps land on the Agents tab.Files
apps/mobile/src/lib/notifications.ts— adds the apply logic, the background task, and the foreground suppression.apps/mobile/src/lib/notification-path.ts— routes a glanceable tap to the Agents tab.apps/mobile/src/app/_layout.tsx— registers the background handler at module scope.apps/mobile/app.config.ts— enables background remote notifications.apps/mobile/package.json— addsexpo-task-manager.An iOS delivery registrar registers and unregisters the Live Activity and push-to-start tokens. Registration waits for any in-flight logout unregister to settle, and unregistration reports the tokens it attempted so logout can tombstone them.
Files
apps/mobile/src/lib/glanceable/delivery-registration.ts— new registrar wiring the two token mutations.apps/mobile/src/lib/glanceable/sink-registry.ts— adds the delivery hook and the token-only context.apps/mobile/src/lib/auth/push-registration-reconciliation.ts— imports the registrar as a side effect.The iOS Live Activity renders status, counts, and an elapsed timer from the shared content-state. The sink adopts an existing activity after a process restart, guards revisions, marks the surface denied only on a permanent ActivityKit failure, and triggers a one-time Settings prompt from the Agents tab.
Files
apps/mobile/src/glanceable-ios/active-agents-live-activity.tsx— the Live Activity layout with inlined English copy.apps/mobile/src/glanceable-ios/ios-sink.ts— start, update, adopt, end, and token registration.apps/mobile/src/glanceable-ios/view-props.ts— builds the surface props and the content-state.apps/mobile/src/lib/glanceable/activity-kit-prompt.ts— the one-time Settings alert.apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.tsx— shows the alert when the tab regains focus.Logout now awaits activity-token unregistration and tombstones a failed attempt. Reconciliation retries only the recorded tokens, marks the activity part done when it succeeds, and orders registration against the unregister so a new session's tokens are never re-deleted.
Files
apps/mobile/src/lib/auth/logout-cleanup.ts— extends the tombstone with activity tokens and awaits unregistration.apps/mobile/src/lib/auth/logout-reconciliation.ts— retries the recorded tokens and marks the activity part done.Tests: 14 test files updated across the mobile, web, and notifications suites.
Generated: 1 lockfile updated and 2 Drizzle migration metadata files regenerated.
Verification
Manual, on a real Android emulator and an iOS simulator, against the local stack. Two live cloud-agent sessions were seeded (one needs input, one working), so every screenshot below carries real data, not a forced snapshot.
iOS 26.5 simulator:
systemSmallandsystemMedium, Lock Screen Live Activity, and the Dynamic Island all show the same counts.systemMediumdraws the needs-input wait beside its label.Android emulator,
kilo_glanceable_api361:Automated: 660 test files and 8928 tests pass. Typecheck, lint, i18n catalogs, and knip are clean.
Visual Changes
iOS — Home Screen widget, both families
iOS — Dynamic Island
iOS — Lock Screen Live Activity
Android — widget at 4x2 and 2x1
Android — Live Update
Both platforms — no work in progress
Human steps:
Notes: none.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
audit-w8b-live-activities-3cf8— feat(mobile): add glanceable agents snapshot contract #5535audit-w8b-live-activities-3cf8-s2— feat(mobile): add iOS Live Activity and widgets #5553audit-w8b-live-activities-3cf8-s3— feat(mobile): add Android agents widget and live update #5585audit-w8b-live-activities-3cf8-s4— feat(mobile): deliver glanceable snapshot updates #5620 ← this PR (tip)