Repository navigation
feat(provider-review): add server-side GitLab and Bitbucket review layer for mobile (part 1/2) - #6006
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryNo PR source changed since the previously reviewed commit Incremental Verification
Files Reviewed (39 files)
Previous Review Summaries (11 snapshots, latest commit 20e0765)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 20e0765)Status: No Issues Found | Recommendation: Merge Executive SummaryNo PR source changed since the previously reviewed commit Incremental Verification
Files Reviewed (40 files)
Previous review (commit 52563e4)Status: No Issues Found | Recommendation: Merge Executive SummaryThe rebase onto base Incremental Verification
Files Reviewed
Previous review (commit 667a7d4)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental verification of the four prior findings confirms each is fixed at the current head, and no new defect appears on the changed lines. Files Reviewed (4 files)
Resolved Since Previous ReviewThe four findings from commit
Previous review (commit b654fe8)Status: 4 Issues Found | Recommendation: Address before merge Executive SummaryThe highest-risk finding is that Bitbucket thread resolution writes Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (21 files)
Fix these issues in Kilo Cloud Previous review (commit 8159e9f)Status: 4 Issues Found | Recommendation: Address before merge Executive SummaryThe highest-risk finding is that Bitbucket thread resolution writes Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (21 files)
Fix these issues in Kilo Cloud Previous review (commit ab7f50f)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change folds each GitLab diff page into the running counters on arrival and drops it, resolving the prior peak-memory suggestion with no behavior change, and adds a focused test for the page-bound walk. Overview
Resolved Since Previous ReviewThe prior Files Reviewed (2 files)
Previous review (commit 6179f6f)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe Bitbucket and GitLab read-layer fixes land cleanly; the only new finding is avoidable peak-memory retention from raising the GitLab diff page bound, with no new correctness or security defects introduced. Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Resolved Since Previous ReviewThe four findings from the prior review are fixed at
Previous review (commit 38c7c32)Status: 4 Issues Found | Recommendation: Address before merge Executive SummaryThe Bitbucket read layer drops replies and fails to degrade on cursor-page task errors; GitLab read pagination and change counts under-report for large MRs. Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (36 files)
Previous review (commit f539fec)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit 63f7e56)Status: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Files Reviewed (38 files)
Previous review (commit ebe532a)Status: 9 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (272 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
ebe532a to
12aa797
Compare
…yer for mobile (part 1/2) #6006
0076b48 to
63f7e56
Compare
…yer for mobile (part 1/2) #6006
ccfd7b9 to
8159e9f
Compare
…yer for mobile (part 1/2) #6006
3c15f97 to
8575cd8
Compare
…yer for mobile (part 1/2) #6006
433e27e to
6f291c1
Compare
…yer for mobile (part 1/2) #6006
030c6d4 to
b654fe8
Compare
…yer for mobile (part 1/2) #6006
b654fe8 to
667a7d4
Compare
…yer for mobile (part 1/2) #6006
e994821 to
52563e4
Compare
|
(bot) ## Live proof (proof-only request; no code change) Ran on ios; the request asked for any platform. This request asked for live proof of existing behaviour. There is no diff; the verify round ran the must-run scenarios and recorded the evidence below.
|
…yer for mobile (part 1/2) #6006
5f4f72d to
20e0765
Compare
…yer for mobile (part 1/2) #6006
20e0765 to
e8c6b3d
Compare
… workflow (part 2/2) (#6021) * feat(provider-review): add server-side GitLab and Bitbucket review layer for mobile (part 1/2) #6006 * feat(mobile): bring GitLab and Bitbucket code review up to the GitHub workflow (part 2/2) #6021 * fix: kwf-fix-review-c381 patch delivery * fix: kwf-fix-ci-fix-ebd8 patch delivery * feat(provider-review): add server-side GitLab and Bitbucket review layer for mobile (part 1/2) #6006 * test(mobile): one safe-area mock drives both inset cases The merge left two vi.mock calls for react-native-safe-area-context in the new-session-configure-form suite. The later call won, so the bottom inset read 0 and the navigation-bar clearance case measured 32 instead of 60. One mock now returns the shared insetsState. Each case sets the inset it needs and restores it. * feat(provider-review): add server-side GitLab and Bitbucket review layer for mobile (part 1/2) #6006 * merge: origin/main into kwf/bring-mobile-gitlab-and-bitb-3792-l30 * chore: regenerate the lock file for this branchs patch set patchedDependencies records the HASH of each patch file, so a branch that edits patches/expo-router@57.0.20.patch cannot carry mains lock file. The frozen install refused it and catalog (PR) failed.
Mobile GitLab and Bitbucket had no server-side review layer: only GitHub had an authorized PR surface, a ledger-protected write path, and provider identity contracts. This PR adds that foundation for GitLab and Bitbucket Cloud without regressing the GitHub router.
Changelog for users
Changelog for maintainers
@kilocode/app-shared/provider-review: provider-discriminated refs, DTOs,providerPrRefKey, and a capability vocabulary withproviderPrTermfor provider-correct wording.resolve_thread,unresolve_thread,enable_auto_merge,disable_auto_merge). An absent orgithubplatform keeps the legacy bytes, so in-flight GitHub keys do not rotate.no-store.providerReviewRoutermounts on the root and mobile routers; organization inputs runensureOrganizationAccessfirst.githubPrReviewis untouched except exportingassertTermsAcceptedfor the shared terms gate.providerPrRefKeyplus a 16-hex-char fingerprint hash. Ambiguous failures markreconcile_pending; merge reconcile re-reads the authoritative state owner-bound before replay; a partially committed inline batch reports retryable so a retry cannot duplicate comments./2.0/next URLs inside a repository path guard; GitLab cursors bind page numbers to project or owner identity; responses are size-capped and the GitLab transport pins the DNS-resolved address.provider-review-router.ts(ledger orchestration, error taxonomy) andbitbucket-authorization.ts(token release). Risky spots: the 16-char fingerprint slice behind ledger keys, andenableAutoMergereusing GitLab's merge endpoint, refused without an active pipeline.PR stack (merge bottom to top)
kwf/bring-mobile-gitlab-and-bitb-3792-l1) ← this PRkwf/bring-mobile-gitlab-and-bitb-3792-l30)E2E proof
— log excerpts