Skip to content

Reload editor on preference changes - #122

Merged
lukepistrol merged 4 commits into
CodeEditApp:mainfrom
ben-p-commits:reload-editor
Jan 18, 2023
Merged

lukepistrol merged 4 commits into
CodeEditApp:mainfrom
ben-p-commits:reload-editor

Conversation

@ben-p-commits

Copy link
Copy Markdown
Contributor

What is it?

Addresses bug: CodeEditApp/CodeEditTextView#110, and maybe others- but I need to hunt them down.

Ensures that highlights aren't lost when processing these updates.

UI Behavior

live-updates.mp4

@ben-p-commits
ben-p-commits marked this pull request as ready for review January 18, 2023 17:00
@lukepistrol
lukepistrol requested review from lukepistrol and thecoolwinter and removed request for thecoolwinter January 18, 2023 17:04

@thecoolwinter thecoolwinter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet work!

@ben-p-commits ben-p-commits changed the title Reload editor Reload editor on preference changes Jan 18, 2023
@lukepistrol
lukepistrol merged commit 9f79fa8 into CodeEditApp:main Jan 18, 2023
arvoisa added a commit to arvoisa/CodeEditSourceEditor that referenced this pull request Sep 28, 2026
…fixes

0.12.1 plus CodeEditTextView PRs CodeEditApp#122 (words duplicated at wrap
boundaries), CodeEditApp#123 (Cmd+A not highlighting the last line) and CodeEditApp#126 (drag
selection freezing over the gutter), pinned by revision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants